Skip to content

Change the banner content to promote Q2 survey#13441

Merged
sfshaza2 merged 1 commit into
mainfrom
zanderso-patch-1
May 29, 2026
Merged

Change the banner content to promote Q2 survey#13441
sfshaza2 merged 1 commit into
mainfrom
zanderso-patch-1

Conversation

@zanderso
Copy link
Copy Markdown
Member

Description of what this PR is changing or adding, and why:

The survey is planned to run from 6/1 to 6/12. This PR should not land before 6/1.

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

Updated bannerHtml to promote Q2 survey.
@zanderso zanderso requested review from a team and sfshaza2 as code owners May 29, 2026 16:17
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the site banner in sites/docs/src/data/site.yml to promote the Q2 survey instead of the Flutter 3.44 release. The review feedback suggests improving the link by removing the first-person pronoun 'our' to comply with style guidelines and adding rel="noopener" to the anchor tag for security.

Watch <a href="https://www.youtube.com/watch?v=I1uIbGh1dGE&t=1s" target="_blank">What's new in Flutter</a> and
read the <a href="https://blog.flutter.dev/whats-new-in-flutter-3-44-b0cc1ad3c527" target="_blank">blog post</a>.
Help improve Flutter!
<a href="https://google.qualtrics.com/jfe/form/SV_3drKjSfjNeLZfq6?Source=Website" target="_blank">Take our Q2 survey</a>.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To adhere to the Google Developer Documentation Style Guidelines mentioned in the PR checklist, avoid using the first-person pronoun 'our' by changing it to 'the'. Additionally, for security, add rel="noopener" to the target="_blank" link to prevent potential reverse tabnabbing.

  <a href="https://google.qualtrics.com/jfe/form/SV_3drKjSfjNeLZfq6?Source=Website" target="_blank" rel="noopener">Take the Q2 survey</a>.

@flutter-website-bot
Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit e931e56):

https://flutter-docs-prod--docs-pr13441-zanderso-patch-1-t819w29n.web.app

Copy link
Copy Markdown
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 9f090e2 into main May 29, 2026
12 checks passed
@sfshaza2 sfshaza2 deleted the zanderso-patch-1 branch May 29, 2026 16:44
@zanderso
Copy link
Copy Markdown
Member Author

Oops. This wasn't supposed to land until Monday =) I will click the revert button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants