Remove Rosetta note from iOS setup page#13450
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes an outdated note regarding Rosetta requirements for Apple Silicon Macs from the iOS setup documentation. The reviewer pointed out that removing this note leaves an unused Apple Silicon link reference at the bottom of the file, which should also be removed to keep the markdown clean.
I am having trouble creating individual review comments. Click here to see my feedback.
sites/docs/src/content/platform-integration/ios/setup.md (77-81)
Removing this note leaves the [Apple Silicon] link reference at the bottom of the file (line 91) unused. Please remove the unused reference definition [Apple Silicon]: https://support.apple.com/en-us/116943 to keep the markdown file clean.
Collaborator
|
Staged preview of the updated docs.flutter.dev site (updated for commit cbbe220): https://flutter-docs-prod--docs-pr13450-misc-remove-rosetta-no-bizwv2y6.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the necessary commit wasn't included in 3.41.9, so we should either update this to 3.44 or remove it. I chose to remove it as new developers following the setup instructions will likely be using an up-to-date Flutter SDK and if not, the tooling should prompt them if/when the installation of Rosetta is necessary. This keeps the docs up to date and focused for the majority of developers.
Resolves #13369
Closes #12178