Skip to content

Ensure flutter-for/react-native is mobile-friendly by making images responsive#1790

Merged
chalin merged 2 commits intomasterfrom
chalin-flutter-for-images-1128
Nov 29, 2018
Merged

Ensure flutter-for/react-native is mobile-friendly by making images responsive#1790
chalin merged 2 commits intomasterfrom
chalin-flutter-for-images-1128

Conversation

@chalin
Copy link
Copy Markdown
Contributor

@chalin chalin commented Nov 29, 2018

Staged at https://ng2-io.firebaseapp.com/docs/get-started/flutter-for/react-native-devs


Screenshots

Before

screen shot 2018-11-29 at 13 54 31

After

screen shot 2018-11-29 at 13 57 12

- Make flutter-for/react-native mobile friendly by making images responsive.
- Move flutter-for images into _assets folder (contributes to #1303)
- Fix 404 for `/docs/get-started/flutter-for/react-native-devs/images`
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Nov 29, 2018
Copy link
Copy Markdown
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what an effort!!! LGTM

@chalin chalin changed the title Make flutter-for/react-native mobile friendly by making images responsive Ensure flutter-for/react-native is mobile-friendly by making images responsive Nov 29, 2018
@chalin chalin merged commit efced27 into master Nov 29, 2018
@chalin chalin deleted the chalin-flutter-for-images-1128 branch November 29, 2018 20:06
chalin added a commit that referenced this pull request Nov 29, 2018
chalin added a commit that referenced this pull request Nov 30, 2018
Make android-ios-figure-pair.md a global include template and remove the two local copies. There is no content change in this PR.

Followup to #1790
chalin added a commit that referenced this pull request Dec 1, 2018
chalin added a commit that referenced this pull request Dec 1, 2018
chalin added a commit that referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants