[Windows] Document the show window migration#9269
Merged
parlough merged 2 commits intoflutter:mainfrom Aug 19, 2023
Merged
Conversation
loic-sharma
requested review from
atsansone,
parlough and
sfshaza2
as code owners
This was referenced Aug 18, 2023
parlough
approved these changes
Aug 19, 2023
Member
There was a problem hiding this comment.
Thanks so much for staying on top of this, writing the doc, and the extra details! I really appreciate it :D
As a reference for next time, consider submitting the migration guide once the necessary changes land. These guidelines can still be helpful for users who follow beta. If something changes before stable is released, we can always readjust :)
loic-sharma
added a commit
to flutter/gallery
that referenced
this pull request
Sep 1, 2023
Migrate the Gallery app to ensure the window is shown. Part of flutter/flutter#127695 Used by flutter/website#9269
genx7up
pushed a commit
to aweps/gallery
that referenced
this pull request
Dec 13, 2023
Migrate the Gallery app to ensure the window is shown. Part of flutter/flutter#127695 Used by flutter/website#9269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flutter 3.7 and 3.10 has a race condition that can result in the window not being shown (see flutter/flutter#119415). Projects need to be migrated to fix this bug.
Most Windows projects will be migrated automatically by running
flutter windows buildorflutter rununless they've done significant changes to theirwindows/runner/flutter_window.cppfile.This documents how to migrate a Windows project manually. Note that this fix depends on an API that was added in Flutter 3.13. In other words, projects that are still using Flutter 3.7 or 3.10 should not do this migration.
Issues fixed by this PR (if any): flutter/flutter#127695
Presubmit checklist