Conversation
in the original file the option to change the frontlayer's color wasn't available from the scaffold's constructor so i made it possible here.
|
@WieFel Do you think this is needed? Can't applying background color to |
LGTM. We already have However, I think it's more convenient to have the two color properties present. |
|
|
||
| final Color frontLayerBackgroundColor; |
There was a problem hiding this comment.
@farmery please add documentation similar to backLayerBackgroundColor!
|
|
||
| Widget _buildFrontPanel(BuildContext context) { | ||
| return Material( | ||
| color: this.widget.frontLayerBackgroundColor?? Colors.white, |
There was a problem hiding this comment.
@farmery please remove the ?? Colors.white.
Docs of Material.color say: "By default, the color is derived from the [type] of material."
So, if widget.frontLayerBackgroundColor is not set (= is null), Material handles the initialisation of the color itself.
|
@farmery Please do necessary changes. Awaiting for it. |
|
@WieFel Apply the changes yourself, and let's merge this, so that it lands in the next release. |
|
@WieFel You will have to push changes to |
|
This feature has landed with @farmery Check yourself on README!! |
|
thank you very much! so sorry for not responding all these while.
…On Wed, Oct 28, 2020 at 7:32 AM Harsh Bhikadia ***@***.***> wrote:
This feature has landed with v0.4.7 on pub.dev
<https://pub.dev/packages/backdrop/versions/0.4.7>.
@farmery <https://github.com/farmery> Check yourself on README!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANRBHWFSJS4UULHDDEI6ZFTSM63HXANCNFSM4SCHMRAQ>
.
|
3 participants
in the original file the option to change the frontlayer's color wasn't available from the scaffold's constructor so i made it possible here.