chewie `v1.8.6`, `v1.8.7` does not compile on flutter `v3.25.7`

[xsahil03x]

As mentioned in the title, the min supported flutter version for chewie ^1.8.7 was flutter v3.19 but it does not compile because of the new color.withValue is only available in the latest flutter v3.27.0.

One of the change that fails is
https://github.com/fluttercommunity/chewie/blob/v1.8.6/lib/src/material/material_desktop_controls.dart#L593-L596

We should instead ignore the lint for versions prior to chewie ^1.9.0.

[diegotori]

@xsahil03x please upgrade to Flutter 3.27 in order to use versions beyond 1.8.5.

Also, it's not a good idea to ignore lints, otherwise, when a new version comes out, one that removes those ignored methods, it will still break. We'd rather nip it in the bud now than later on.

[xsahil03x]

@diegotori , we support upto latest - 1 flutter version for our SDK's so it's not feasible to make the min required version to 3.27 for us.

A simple fix would be release a ^1.8.8 with ignored lints. I can create a new branch tomorrow if you agree.

Also, i agree we should not ignore lints but this is the only way as those methods are not available in the older versions and chewie prior to version 1.9.0 specifies support for upto flutter v3.19.

[diegotori]

@xsahil03x unfortunately, we can't go back and release a 1.8.8. We're already at 1.9.0. Otherwise, we would have to revert a bunch of changes to do this.

I made this absolutely clear in that 1.9.0 requires Flutter 3.27. In the meantime, you can pin the version to 1.8.5 (remove the ^ from the dependency version in your pubspec), until you are ready to move on to 3.27.

[xsahil03x]

Yes, we can just create a new 1.8.8 tag by checking out the tag 1.8.7 and do the changes and publish a release from that tag.

But, sure i will pin the version for now. Thank you for your contributions.

[diegotori]

@xsahil03x but doing it from there will override the 1.9.0 version that was already released.

I can't recall a published version, since pub.dev clearly states Publishing is forever.

[xsahil03x]

Actually, it does not. I have tried it before for some quick fixes for our packages. Pub maintains the sequence number of your published version. But still it might have changed. I will verify if this is still possible and let you know.

Also found this on stackoverflow.

[diegotori]

I can't risk it though. If you want to raise a PR that does this, then I can review it.

Again though, we run the risk of breaking the library once the next version removes it, then it breaks for everyone. Then I get a bunch of issues opened because of it. For now, pin it to 1.8.5, since this library doesn't guarantee backwards compatibility for the current minor version. That's why it was moved to the next minor.

[diegotori]

@xsahil03x to be clear, if enough people want this reverted, then I will create an extension that shadows it, so that the lint ignore is contained into a single place.

I also accept PRs that do this.

[diegotori]

@xsahil03x bottom line, I want to minimize the potential breakage to just one place, instead of multiple places where withOpacity is called.

[xsahil03x]

Yes, one improvement we can do is to also do the lint checks on our min supported flutter version in the workflow. I do the same for all of our packages. You can take a look here.

https://github.com/xsahil03x/super_paging/blob/main/.github/workflows/super_paging.yaml#L22
https://github.com/GetStream/stream-video-flutter/blob/main/.github/workflows/legacy_version_analyze.yml

[diegotori]

@xsahil03x just published version 1.9.1 which isolates the deprecated withOpacity call into a single compatibility extension method, with full documentation so that it can be removed once the Flutter team does.

[xsahil03x]

@diegotori nice work on the new workflows too 🚀