-
Notifications
You must be signed in to change notification settings - Fork 352
[Feature][ios] Allow to define custom task #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][ios] Allow to define custom task #331
Conversation
|
@tuyen-vuduc hi & sorry for not coming back to this PR for such a long time. To be honest I don't fully understand it yet, perhaps the change set is too big. From my understanding:
|
|
@ened Yeah, that's right.
In my last two projects, we need more than one tasks with different names. And I think it'll be more natural to define the name we want, not the name hard-coded. That's why I create this PR. |
9924a26 to
7c19d72
Compare
ened
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could split this PR.
There are changes in iOS example setup, example file itself (the new nesting due to the scrollview prevents efficient review) and the good change itself. Possible?
android/src/main/kotlin/be/tramckrijte/workmanager/WorkmanagerCallHandler.kt
Outdated
Show resolved
Hide resolved
|
are there any updates on this? having multiple tasks on iOS would be great. |
|
@tuyen-vuduc any chance you could pick this up again? |
|
@ened Yeah, I am about to finish this within the week. |
7c19d72 to
70291cd
Compare
|
@ened Could you check why the UT fails on CI/CD check? |
Can you please install flutter 2.10 on your machine, run |
|
hi @tuyen-vuduc, does https://stackoverflow.com/a/58224050/375209 help with the error you currently showing in the integration test log? |
ened
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Let's get the docs right and sort the conflict. Then happy to merge.
|
@ened is it ok for merging? |
|
@ened How are you? Are you planning to merge this PR? |
At the moment, the lib doesn't allow to change the name of the background task on iOS, hence only one background task is allowed.
This PR will allow us as developers to define as many tasks as we desire and with any unique names we want.
There is an extra step to let iOS know about these names in our
AppDeledgate.cs.Readme is updated with instructions.