[connectivity_plus] Opening the application causes onConnectivityChanged to emit two events

[cal-g]

System info

Platform the Issue occurs on: iOS
Plugin name: connectivity_plus
Plugin version: 2.2.1

Steps to Reproduce

Demo code increments counter when connection is changed to Wifi.
Link to gist

1. Run the gist code on a simulator or real device

When the app is opened the onConnectivityChanged emits two events instead of just one. On Android it correctly emits just one event. I'm guessing this can be a bug on the iOS.
The video attached is the release build of the demo gist on a iPhone 8

Since, there are 2 events emitted the counter increments 2 times if WiFi is turned on and 2 is displayed when the app is opened. There are 2 events emitted even if Wifi and Data is turned off.

Expected: Only one event should be emitted.

RPReplay_Final1647367059.1.1.mp4

Running in debug mode on iOS Simulator. "Got a new connectivity status! ::wifi" is printed twice.

Logs

Launching lib/main.dart on iPhone SE (3rd generation) in debug mode...
Running Xcode build...                                                  
 └─Compiling, linking and signing...                         3.5s
Xcode build done.                                            9.6s
flutter: initState
flutter: Got a new connectivity status!  ::wifi
flutter: Got a new connectivity status!  ::wifi
Syncing files to device iPhone SE (3rd generation)...              214ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

💪 Running with sound null safety 💪

Flutter doctor output

✓] Flutter (Channel stable, 2.10.3, on macOS 12.2.1 21D62 darwin-x64, locale en-CA)
    • Flutter version 2.10.3 at /Users/calvin.gonsalves/Desktop/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7e9793dee1 (13 days ago), 2022-03-02 11:23:12 -0600
    • Engine revision bd539267b4
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/calvin.gonsalves/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] VS Code (version 1.65.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.37.20220301

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 99.0.4844.51

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[kuhnroyal]

I stumbled on this issue by chance and tested it with #791
Same result, first event is ConnectivityResult.none and second is ConnectivityResult.wifi.

[kuhnroyal]

I think I fixed this in e0d37a4 (#791) except for hot restarts

[miquelbeltran]

closing, if the issue reappears please say so here and I will reopen the issue

[luis901101]

I have tested the recently published version v2.3.0 and I also tested PR 791 and I'm still facing the same issue.
The commit I specifically tested from PR 791 was:

connectivity_plus: #^2.3.0
    git:
      url: https://github.com/kuhnroyal/plus_plugins
      path: packages/connectivity_plus/connectivity_plus
      ref: d7b83c425f63a049d5195df99848c33a9eb1e894

[kuhnroyal]

@luis901101 On which iOS version did you test?
The line which can potentially cause double emit is still there: https://github.com/fluttercommunity/plus_plugins/blob/main/packages/connectivity_plus/connectivity_plus/ios/Classes/SwiftConnectivityPlusPlugin.swift#L67

I remember this also being a timing issue. In my test app on iOS 15 I only had one event.
Removing the line sometimes leads to no initial event being fired.

Will try to test this again.

[kuhnroyal]

Also this may play a role here: #791 (comment)

[luis901101]

Tested in iOS 15.3.1 and 15.4.1

[838]

@kuhnroyal @miquelbeltran

I also have the same issue on iOS. When listening to the onConnectivityChanged or when connectivity changes, the onConnectivityChanged will be emitted twice with ConnectivityResult.none as the first value.

[miquelbeltran]

Reopened. Just to be sure, is this a big issue if you receive two events? How is that affecting your code? (just want to understand better the scope of this problem)

[kuhnroyal]

@838 Which iOS version and did the same happen before the 2.3.0 release?