Skip to content

Conversation

@vbuberen
Copy link
Collaborator

Description

This PR adds https://github.com/invertase/github-action-dart-analyzer Action to automatically add review comments to PRs opened in this repository. I believe it will help maintainers to get better visual feedback, so less people will ignore analyzer issues due to no requirement to go through Actions logs.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@vbuberen vbuberen added the CI/CD Everything related to automated builds and deployments label Jan 13, 2022
@vbuberen vbuberen requested review from elias8 and mhadaily January 13, 2022 19:04
Copy link
Member

@elias8 elias8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vbuberen
Copy link
Collaborator Author

Increased time limit for Analyzer job, since it looks like 15 mins isn't enough.

@vbuberen
Copy link
Collaborator Author

Had issue with working-directory specified for added Action and this is why the job was canceled due to timeout. Finally resolved the issue and returned 15 mins limit back.

@vbuberen vbuberen merged commit 33b21a7 into fluttercommunity:main Jan 14, 2022
@vbuberen vbuberen deleted the feature/analyzer_action branch January 14, 2022 22:30
@elias8
Copy link
Member

elias8 commented Jan 14, 2022

Had issue with working-directory specified for added Action and this is why the job was canceled due to timeout. Finally resolved the issue and returned 15 mins limit back.

I was trying to figure out what went wrong. Thanks for fixing.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI/CD Everything related to automated builds and deployments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants