fix(share_plus): Fix 'share text' not showing when share files#907
Conversation
|
I've been testing this, and I have no problem approving and merging, but I fail to see what problem is it solving. When I test this PR example against multiple apps: Telegram, Google Keep, Twitter, etc. sharing both images and text, only the image gets shared. I am unable to see if this is a limitation with share_plus or a general problem with all apps, and I am not sure if this PR attempts to fix this problem or something else. |
I attached two videos to show the difference before and after this PR when I try to share a text with an image through the Email or Twitter apps. These videos are captured from my iPhone 12 ios 15.5 before video before.480.mp4after video after.480.mp4The code added to this PR code adds the share text to some apps like Twitter, email, or telegram app will display the share text with an image, and some apps will not read the text just the image like the Facebook app (the Facebook app will read just hashtag text like #salah I don't know why 😐), and WhatsApp app will just read the text and will ignore the image. I believe each app will handle the share items in its custom way. but of course, we need to add the share text to |
|
Thanks for the videos! Something was wrong when I tested this then, because I couldn't see the shared text on Twitter, but I see that it works on your case |
|
We forgot to update the pubspec.yml before merging, I will fix that on main directly |
|
4.0.10 published now |
Description
when the user uses
shareFilesorshareWithResultmethods to share a file or files,textargument was ignored and not added toshare:itemson the IOS platform, so I just add the text toshare:items.Related Issues
*no related issues
Checklist
pubspec.yamlandCHANGELOG.md.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?