fix: keep Pick.saveFile source-compatible with file_picker 12#101
Merged
Conversation
file_picker 12 made FilePicker.saveFile's fileName and bytes required and non-null, breaking the analyzer build under a fresh pub get that resolves the newer file_picker (master CI is currently red on this). Pick.saveFile keeps its nullable facade surface but guards both arguments before forwarding, so it type-checks against file_picker 11 and 12 and fails with a clear ArgumentError on null instead of an unhelpful type error.
There was a problem hiding this comment.
Pull request overview
This PR fixes a current analyzer break on master caused by file_picker v12 making FilePicker.saveFile’s fileName and bytes parameters required/non-null, by adding a null-guard in Magic’s Pick.saveFile facade while keeping the facade signature source-compatible.
Changes:
- Add an early
ArgumentErrorguard inPick.saveFilewhenfileName/bytesare null before forwarding toFilePicker.saveFile. - Document the fix in
CHANGELOG.mdunder [Unreleased] > Fixed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/src/facades/pick.dart | Adds a guard to keep Pick.saveFile compatible across file_picker 11/12. |
| CHANGELOG.md | Adds an unreleased “Fixed” entry describing the compatibility change. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
anilcancakir
force-pushed
the
fix/pick-savefile-non-null
branch
from
9f84b19 to
8baa6aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-existing master breakage (not introduced by a friction PR).
file_picker 12madeFilePicker.saveFile'sfileNameandbytesparametersrequiredand non-null. A freshflutter pub geton current CI resolves the newer file_picker, soPick.saveFilefails analysis withargument_type_not_assignableatlib/src/facades/pick.dart:368-369(master's Lint & Test is red, see the #96 dep-bump run).Pick.saveFilekeeps its nullable facade signature but guards both arguments before forwarding, so the call type-checks against file_picker 11 and 12 and a null argument fails with a clearArgumentErrorinstead of an unhelpful type error. Unblocks master CI (and every open magic PR, including #100).