fix: block file_picker 12.0.0-beta prerelease (#1)#98
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the file_picker dependency constraint to avoid consumers resolving a prerelease (12.0.0-beta) that breaks Pick.saveFile()’s nullable signature, and documents the change in the changelog.
Changes:
- Update
pubspec.yamlto narrow the allowedfile_pickerversions. - Add a
[Unreleased]changelog entry explaining the constraint change and rationale.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pubspec.yaml | Narrows the file_picker version range to prevent resolving incompatible versions. |
| CHANGELOG.md | Documents the file_picker constraint change and its motivation. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Tighten the file_picker constraint from ">=11.0.2 <13.0.0" to ">=11.0.2 <12.0.0". The wider bound let 12.0.0-beta resolve, whose non-null saveFile parameters break the nullable signature in lib/src/facades/pick.dart.
anilcancakir
force-pushed
the
fix/file-picker-prerelease-constraint
branch
from
5f9871f to
a9ca032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tighten the
file_pickerconstraint from>=11.0.2 <13.0.0to>=11.0.2 <12.0.0.Why
The wider bound let
12.0.0-betaresolve, whose non-nullsaveFileparameters break the nullable signature inlib/src/facades/pick.dart, failing the build for consumers.Verification
flutter pub getresolvesfile_pickerto 11.0.2;dart analyzeclean.pick.dartuntouched.Fixes REPORT.md bug #1.