fix: resolve DialogShell bottom overflow when body exceeds viewport#22
Merged
anilcancakir merged 4 commits intomainfrom Apr 6, 2026
Merged
fix: resolve DialogShell bottom overflow when body exceeds viewport#22anilcancakir merged 4 commits intomainfrom
anilcancakir merged 4 commits intomainfrom
Conversation
Remove `flex flex-col` from the outer WDiv className — the Wind UI Flex widget broke constraint propagation to the inner Column, causing overflow instead of scrolling when content exceeded maxHeight. The WDiv now acts as a plain styled container, letting Column receive constraints directly from ConstrainedBox. Closes #21
There was a problem hiding this comment.
Pull request overview
Fixes a bottom overflow in MagicStarterDialogShell when the dialog body exceeds the available viewport height by ensuring height constraints propagate correctly so the body area can scroll.
Changes:
- Removed Wind
flex flex-colclasses from the outerWDivinMagicStarterDialogShellto avoid breaking constraint propagation into the innerColumn. - Added a widget test covering the “large body in small viewport” scenario to ensure no bottom overflow and that footer remains rendered.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/src/ui/widgets/magic_starter_dialog_shell.dart | Removes flex styling from the container WDiv so the constrained Column + Flexible(ListView) layout can scroll instead of overflowing. |
| test/ui/widgets/magic_starter_dialog_shell_test.dart | Adds a regression test for large body content in a constrained viewport to catch overflow issues. |
Verify the ListView is actually scrollable by dragging and asserting scroll offset increases, and that the footer remains visible after scrolling — addresses Copilot review feedback.
Auth facade now resolves AuthManager from IoC container instead of using
a static singleton. All 16 test files updated to bind AuthManager via
Magic.singleton('auth', () => AuthManager()) before accessing
Auth.manager. Bumped minimum magic dependency to ^1.0.0-alpha.7.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flex flex-colfrom outer WDiv inMagicStarterDialogShell— the Wind UI Flex widget broke constraint propagation to the inner Column, causing bottom overflow instead of scrolling when body content exceededmaxHeightTest plan
body scrolls without overflow when content exceeds viewport— 20 items × 60px in 400×600 viewportflutter analyze: 0 issuesCloses #21