feat: release GIL for most "run_block_on" calls#388
Merged
digikata merged 1 commit intofluvio-community:mainfrom Mar 11, 2024
Merged
feat: release GIL for most "run_block_on" calls#388digikata merged 1 commit intofluvio-community:mainfrom
digikata merged 1 commit intofluvio-community:mainfrom
Conversation
Contributor
|
Thanks for the PR @dariogoetz, we appreciate you taking the time to submit it. We'll queue this up to review and test it right away! |
Contributor
|
Looks good to me, added an issue to expand further to other areas Thanks again @dariogoetz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wraps most
run_block_oncalls in apy.allow_threadsfunction, releasing the Python GIL for the duration of therun_block_oncall. This is especially important forPartitionConsumerStream.nextwhich might block indefinitely.The issue arose with me, when running a
PartitionConsumerin a separate thread and using thestreammethod. The underlying call toPartitionConsumerStream.nextwas waiting for incoming messages while holding the Python GIL, effectively prohibiting the main thread to do any work.I think that releasing the GIL is mostly important for the
PartitionConsumerStream.nextmethod, because it may block indefinitely (if no messages arrive), but I wrapped all otherrun_block_oncalls as well, while I was at it.I left out the instances of
run_block_onin the context ofCloudandCloudAuthas I have not worked with those, yet.