Conversation
fraidev
force-pushed
the
graceful_shutdown
branch
4 times, most recently
from
179750b to
50a638a
Compare
fraidev
force-pushed
the
graceful_shutdown
branch
2 times, most recently
from
dfe3e67 to
ef9bef8
Compare
fraidev
force-pushed
the
graceful_shutdown
branch
from
ef9bef8 to
87e9e76
Compare
fraidev
force-pushed
the
graceful_shutdown
branch
3 times, most recently
from
d6dcc62 to
e38245b
Compare
sehz
reviewed
Jan 8, 2025
fraidev
force-pushed
the
graceful_shutdown
branch
2 times, most recently
from
dfc531d to
0c61ecd
Compare
fraidev
force-pushed
the
graceful_shutdown
branch
from
0c61ecd to
38d8532
Compare
digikata
reviewed
Jan 8, 2025
.github/workflows/ci.yml
Outdated
| os: [ubuntu-latest] | ||
| rust: [stable] | ||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | ||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"] |
Contributor
There was a problem hiding this comment.
Since you're updating tested python versions, can you remove python 3.8, it's end of life. https://devguide.python.org/versions/
Contributor
Author
There was a problem hiding this comment.
sure, also bump the python_requires from 3.8>= to 3.9>=?
sehz
reviewed
Jan 8, 2025
sehz
reviewed
Jan 8, 2025
fraidev
force-pushed
the
graceful_shutdown
branch
from
479e1df to
a0fce51
Compare
sehz
approved these changes
Jan 8, 2025
sehz
left a comment
sehz
left a comment
There was a problem hiding this comment.
Seems reasonable. Since not expert on PyO3, can't comment on that section.
Note that this still use experimental branch. It should use release version before release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.