Conversation
fraidev
force-pushed
the
bump_v0.17.3
branch
30 times, most recently
from
6aedfc4 to
04699a3
Compare
digikata
reviewed
May 21, 2025
Contributor
There was a problem hiding this comment.
does the classifiers replace setup.py classifiers? Some of the info is duplicated. It would be nice if it only occurred in one place
Contributor
Author
There was a problem hiding this comment.
yeah, I got some warning that we will not be able to publish package with setup.py very soon, IIRC October.
I removed it completely now. All CI and makefile are using the new pyproject now.
fraidev
force-pushed
the
bump_v0.17.3
branch
19 times, most recently
from
9c34687 to
f6a77c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using a fork of cross, because I need this fix: cross-rs/cross#1682