Skip to content

Removes deprecated policy/v1beta1 API from PodDisruptionBudget templates#1885

Merged
stefanprodan merged 1 commit intofluxcd:mainfrom
renatovassaomb:rv/drop-policy-v1beta1
Mar 11, 2026
Merged

Removes deprecated policy/v1beta1 API from PodDisruptionBudget templates#1885
stefanprodan merged 1 commit intofluxcd:mainfrom
renatovassaomb:rv/drop-policy-v1beta1

Conversation

@renatovassaomb
Copy link
Copy Markdown
Contributor

Summary

This PR removes deprecated policy/v1beta1 API from flagger and load tester templates, since it stopped being served in Kubernetes 1.25, which is EOL since Oct 2023.

Changes

Testing

Local templating with helm template and helm install --dry-run:

> helm template flagger ./charts/flagger --set podDisruptionBudget.enabled=true | head                                             
---
# Source: flagger/templates/pdb.yaml
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: flagger
  namespace: default
spec:
  minAvailable: 1
  selector:

> helm template flagger ./charts/loadtester --set podDisruptionBudget.enabled=true | head    
---
# Source: loadtester/templates/pdb.yaml
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: flagger-loadtester
spec:
  minAvailable: 1
  selector:
    matchLabels:
> helm install flagger ./charts/flagger --dry-run --set podDisruptionBudget.enabled=true | head -n 15
level=WARN msg="--dry-run is deprecated and should be replaced with '--dry-run=client'"
NAME: flagger
LAST DEPLOYED: Fri Mar  6 10:18:28 2026
NAMESPACE: default
STATUS: pending-install
REVISION: 1
DESCRIPTION: Dry run complete
TEST SUITE: None
HOOKS:
MANIFEST:
---
# Source: flagger/templates/pdb.yaml
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: flagger

> helm install flagger ./charts/loadtester --dry-run --set podDisruptionBudget.enabled=true | head -n 15
level=WARN msg="--dry-run is deprecated and should be replaced with '--dry-run=client'"
NAME: flagger
LAST DEPLOYED: Fri Mar  6 10:20:21 2026
NAMESPACE: default
STATUS: pending-install
REVISION: 1
DESCRIPTION: Dry run complete
TEST SUITE: None
HOOKS:
MANIFEST:
---
# Source: loadtester/templates/pdb.yaml
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: flagger-loadtester

@renatovassaomb renatovassaomb changed the title Removes deprecated policy/v1beta1 api from PodDisruptionBudget templates Removes deprecated policy/v1beta1 API from PodDisruptionBudget templates Mar 6, 2026
Signed-off-by: Renato Vassão <renato.vassao@mindbodyonline.com>
@renatovassaomb renatovassaomb force-pushed the rv/drop-policy-v1beta1 branch from 64802e4 to 36a2088 Compare March 6, 2026 13:21
Copy link
Copy Markdown
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.00%. Comparing base (12ee6cb) to head (36a2088).
⚠️ Report is 91 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
- Coverage   39.44%   30.00%   -9.44%     
==========================================
  Files         287      287              
  Lines       22706    18467    -4239     
==========================================
- Hits         8956     5541    -3415     
+ Misses      12777    12195     -582     
+ Partials      973      731     -242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefanprodan stefanprodan merged commit d29c60d into fluxcd:main Mar 11, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants