Skip to content

fix(ms teams notifier): handle 202 status code#1887

Merged
aryan9600 merged 1 commit intofluxcd:mainfrom
mtfurlan:fix/msteams-webhook-status-code
Apr 17, 2026
Merged

fix(ms teams notifier): handle 202 status code#1887
aryan9600 merged 1 commit intofluxcd:mainfrom
mtfurlan:fix/msteams-webhook-status-code

Conversation

@mtfurlan
Copy link
Copy Markdown
Contributor

teams returns a 202 Accepted for webhooks, but flagger was marking this
as an error.

@mtfurlan mtfurlan force-pushed the fix/msteams-webhook-status-code branch from 8c2b831 to 1e9ea57 Compare March 13, 2026 17:11
teams returns a 202 Accepted for webhooks, but flagger was marking this
as an error.

Signed-off-by: Mara Furland <mara@fur.land>
@aryan9600 aryan9600 force-pushed the fix/msteams-webhook-status-code branch from 1e9ea57 to e7375e5 Compare April 16, 2026 18:06
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.19%. Comparing base (ceab3ec) to head (e7375e5).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pkg/notifier/client.go 0.00% 2 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1887      +/-   ##
==========================================
+ Coverage   30.00%   30.19%   +0.19%     
==========================================
  Files         287      288       +1     
  Lines       18467    18532      +65     
==========================================
+ Hits         5541     5596      +55     
- Misses      12195    12201       +6     
- Partials      731      735       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aryan9600 aryan9600 merged commit f7e42a8 into fluxcd:main Apr 17, 2026
18 checks passed
@mtfurlan mtfurlan deleted the fix/msteams-webhook-status-code branch April 17, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants