Fix install and upgrade applying subchart CRDs when condition is false#1123
Merged
matheuscscp merged 1 commit intomainfrom Jan 10, 2025
Merged
Fix install and upgrade applying subchart CRDs when condition is false#1123matheuscscp merged 1 commit intomainfrom
matheuscscp merged 1 commit intomainfrom
Conversation
matheuscscp
force-pushed
the
remove-subchart-crd
branch
from
ab97ed5 to
5ece165
Compare
stefanprodan
approved these changes
Dec 12, 2024
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp 🎖️
matheuscscp
force-pushed
the
remove-subchart-crd
branch
from
ab9c2b0 to
5607fe9
Compare
Member
Author
|
Will add a test for upgrade tomorrow. |
matheuscscp
force-pushed
the
remove-subchart-crd
branch
2 times, most recently
from
f69d2ff to
667a0f8
Compare
darkowlzz
reviewed
Dec 17, 2024
matheuscscp
force-pushed
the
remove-subchart-crd
branch
from
667a0f8 to
2ca8ed1
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
remove-subchart-crd
branch
from
2ca8ed1 to
dd3b66a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #938
Supersedes #941