Add ServerSideApply field to HelmRelease API #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cappyzawa
force-pushed
the
issues/1381
branch
from
8f0bf3c to
dd4f654
Compare
matheuscscp
approved these changes
Jan 15, 2026
Member
matheuscscp
left a comment
matheuscscp
left a comment
There was a problem hiding this comment.
Amazing! Thank you so much! 🚀 (just a nit)
stefanprodan
added
enhancement
Member
|
@cappyzawa Once both comments are fixed we can merge 🙌 |
Member
Author
|
I'll squash the fixup commits once this gets approved. |
stefanprodan
approved these changes
Jan 15, 2026
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @cappyzawa 🏅
Add ServerSideApply field to Install, Upgrade, and Rollback specs
allowing users to control server-side apply behavior per action.
- Install.ServerSideApply: *bool (default based on UseHelm3Defaults)
- Upgrade.ServerSideApply: *string ("true", "false", "auto")
- Rollback.ServerSideApply: *string ("true", "false", "auto")
User-specified values take precedence over defaults. When not
specified, the existing default behavior is preserved.
Signed-off-by: cappyzawa <cappyzawa@gmail.com>
Add end-to-end tests to verify the ServerSideApply field works correctly for install, upgrade, and rollback operations. The tests verify that when serverSideApply is set, the Helm release uses the SSA apply method (apply_method: ssa in the release secret). Signed-off-by: cappyzawa <cappyzawa@gmail.com>
cappyzawa
force-pushed
the
issues/1381
branch
from
848a73d to
280192a
Compare
Member
Author
|
Squashed the fixups, ready for merge 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1381