Make Receiver secretRef optional for generic-oidc#1310
Closed
matheuscscp wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
added
enhancement
Comment on lines
233
to
235
| header. The `token` from the [Secret reference](#secret-reference) is used only | ||
| to salt the webhook path, as with the [`generic`](#generic) type. The request | ||
| is authenticated by the OIDC provider that issued the token. |
Member
There was a problem hiding this comment.
Remove the part about the Secret reference
Member
Author
There was a problem hiding this comment.
It's still used, but optional. Defaults to "".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #1306
Today, the
tokeninside the secret must be present but can be empty. I was planning to set an empty token in the secret to use in my clusters forgeneric-oidc, but then I realized that we can just make the API simpler and not require thesecretRefto be set only forgeneric-oidc.