Support Helm charts from GitRepository sources #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
enhancement
hiddeco
force-pushed
the
helm/charts-from-git
branch
2 times, most recently
from
406dab1 to
3e295e5
Compare
| // package chart | ||
| pkg := action.NewPackage() | ||
| pkg.Destination = artifact.Path | ||
| _, err = pkg.Run(chartPath, nil) |
Member
There was a problem hiding this comment.
How is this dealing with local dependencies and password protected Helm repos?
Member
Author
There was a problem hiding this comment.
It is not, it is expected (at least for now) that they are checked in to Git and made available in the charts/ directory. Otherwise we will run into issues like https://github.com/fluxcd/helm-operator/blob/0ed00cd43a967207fca1f18c10121bd73accb3d4/pkg/helm/v3/dependency.go#L34, or we would have to write our own download manager.
hiddeco
force-pushed
the
helm/charts-from-git
branch
from
3e295e5 to
59c2d58
Compare
stefanprodan
approved these changes
Aug 31, 2020
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
We need to document the limitations compared to helm-op:
- chart changes must be accompanied by a version bump in
Chart.yaml - dependencies must be checked in git
hiddeco
force-pushed
the
helm/charts-from-git
branch
2 times, most recently
from
498611d to
6230e69
Compare
hiddeco
force-pushed
the
helm/charts-from-git
branch
from
6230e69 to
24f47ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #56