Include PATCH rule for events in manager-role #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
changed the title
During high custom resource count / low interval tests, I was greated with a `cannot patch resource "events"` message. This happened due to event compaction, where it will perform a patch instead of a create. By giving the role the permission to do so this should no longer pose a problem.
hiddeco
force-pushed
the
rbac-patch-events
branch
from
7cdf545 to
b5d869d
Compare
stefanprodan
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During high custom resource count / low interval tests, I was greated
with a
cannot patch resource "events"message. This happened due toevent compaction, where it will perform a patch instead of a create.
By giving the role the permission to do so this should no longer pose
a problem.