Conditionally remove artifact from source status #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
bug
stefanprodan
approved these changes
Sep 11, 2020
As it does not allow for error codes to surface
hiddeco
force-pushed
the
status-artifact-reset
branch
from
bf60cb9 to
7c30cb9
Compare
We only want to remove it if it is no longer in storage, otherwise we still want to keep it around till we have a new artifact.
hiddeco
force-pushed
the
status-artifact-reset
branch
from
7c30cb9 to
f40a421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to remove it if it is no longer in storage, otherwise we
still want to keep it around till we have a new artifact.