Cache registry token during Notation verification#2098
Merged
Conversation
matheuscscp
added
bug
The ORAS auth.Client used for Notation signature verification was constructed without a Cache, which ORAS treats as no caching. As a result every request in a single verification (manifest resolve, signature listing, signature manifest and blob fetches) performed its own token exchange against the registry, multiplying token-endpoint traffic by roughly five for each verified artifact. Set Cache to auth.NewCache() so the registry authorization token is fetched once and reused across the requests of a verification. This matches the ORAS and Notation reference clients and does not change verification behaviour or credential resolution; token staleness is still handled by ORAS on a 401. Add unit tests asserting the cache is wired and that the token endpoint is hit once instead of per request. Signed-off-by: Dipti Pai <diptipai89@outlook.com> Assisted-by: GitHub Copilot/Claude Opus 4.8
dipti-pai
force-pushed
the
cache-notation-verify
branch
from
14582b5 to
69305ed
Compare
Member
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ORAS auth.Client used for Notation signature verification was constructed without a Cache, which ORAS treats as no caching. As a result every request in a single verification (manifest resolve, signature listing, signature manifest and blob fetches) performed its own token exchange against the registry, multiplying token-endpoint traffic by roughly five for each verified artifact.
Set Cache to auth.NewCache() so the registry authorization token is fetched once and reused across the requests of a verification. This matches the ORAS and Notation reference clients and does not change verification behaviour or credential resolution; token staleness is still handled by ORAS on a 401.
Add unit tests asserting the cache is wired and that the token endpoint is hit once instead of per request.
Assisted-by: GitHub Copilot/Claude Opus 4.8