Properly escape outer loop for present dependency #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runyontr
force-pushed
the
runyontr-279
branch
from
2204476 to
c6958fb
Compare
hiddeco
approved these changes
Feb 2, 2021
Member
hiddeco
left a comment
hiddeco
left a comment
There was a problem hiding this comment.
Nice catch! 🐛 🎣
Can you please trim down your commit message to a length of 50 characters, and rebase on main?
hiddeco
changed the title
Member
|
This also seems to be the fix for #277: $ kubectl cp source-system/source-controller-6fbd66f546-kz2cg:/data/helmchart/default/dummy-chart/dummy-0.1.0.tgz ./test.tgz
$ tar -tf test.tgz
dummy/Chart.yaml
dummy/Chart.lock
dummy/values.yaml
dummy/templates/NOTES.txt
dummy/templates/_helpers.tpl
dummy/templates/serviceaccount.yaml
dummy/.helmignore
dummy/charts/dependency/Chart.yaml
dummy/charts/dependency/values.yaml
dummy/charts/dependency/templates/NOTES.txt
dummy/charts/dependency/templates/_helpers.tpl
dummy/charts/dependency/templates/serviceaccount.yaml
dummy/charts/dependency/.helmignoreversus the structure reported in #277 (comment). |
To prevent dependencies that are already present locally to be included. Signed-off-by: Thomas Runyon <runyontr@gmail.com>
hiddeco
added
area/helm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277
Fixes #279