Skip to content

Add ignore field to GitRepository spec #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stefanprodan merged 1 commit into from
Jul 9, 2020
Merged

Add ignore field to GitRepository spec #78

stefanprodan merged 1 commit into from
Jul 9, 2020

Conversation

@stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jul 9, 2020

Changes:

  • rename the GitRepository field from SourceIgnore to Ignore
  • add the ignore filed to API docs and provide an example

@stefanprodan stefanprodan added area/docs Documentation related issues and pull requests area/git Git related issues and pull requests labels Jul 9, 2020
@stefanprodan stefanprodan requested a review from hiddeco July 9, 2020 11:39
@stefanprodan
Copy link
Member Author

stefanprodan commented Jul 9, 2020

@erikh FYI we've decided to strip the source prefix to make the API naming less redundant.

@stefanprodan stefanprodan merged commit 4702485 into master Jul 9, 2020
@stefanprodan stefanprodan deleted the ignore-spec branch July 9, 2020 12:18
@erikh
Copy link
Contributor

erikh commented Jul 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees

No one assigned

Labels

area/docs Documentation related issues and pull requests area/git Git related issues and pull requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stefanprodan @erikh @hiddeco