Skip to content

adjust events to support OTX2.3.x - Fix #43#44

Merged
lichtl merged 6 commits intoflyduino:masterfrom
lichtl:otx2.3fix
Feb 5, 2020
Merged

adjust events to support OTX2.3.x - Fix #43#44
lichtl merged 6 commits intoflyduino:masterfrom
lichtl:otx2.3fix

Conversation

@lichtl
Copy link
Copy Markdown
Contributor

@lichtl lichtl commented Dec 30, 2019

Untested

@lichtl lichtl changed the title [WIP] adjust events to support OTX2.3. Cleanup [WIP] adjust events to support OTX2.3. Fix #43 Dec 30, 2019
@lichtl lichtl changed the title [WIP] adjust events to support OTX2.3. Fix #43 [WIP] adjust events to support OTX2.3.x - Fix #43 Dec 30, 2019
@lichtl lichtl changed the title [WIP] adjust events to support OTX2.3.x - Fix #43 adjust events to support OTX2.3.x - Fix #43 Dec 31, 2019
@lichtl
Copy link
Copy Markdown
Contributor Author

lichtl commented Dec 31, 2019

X9D - HW test OK
Xlite - SIM test OK
Horus - SIM test OK

kiss-128x64-lua-scripts-1.0.0.zip
kiss-212x64-lua-scripts-1.0.0.zip
kiss-480x272-lua-scripts-1.0.0.zip

@syrekszymon
Copy link
Copy Markdown

X9D kiss-212x64-lua-scripts-1.0.0.zip

PIDs - don't save
Rates - don't save
TPA - don't save
Filters - don't save
Aalrms - save
VTX - save
D setpoint - save

@lichtl
Copy link
Copy Markdown
Contributor Author

lichtl commented Dec 31, 2019

X9D kiss-212x64-lua-scripts-1.0.0.zip

PIDs - don't save
Rates - don't save
TPA - don't save
Filters - don't save
Aalrms - save
VTX - save
D setpoint - save

Hmm I've tested on X9D+ and PIDs/Rates worked. Since all use the same function (which haven't changed) it should work. Will test later again on hardware but please ensure there is enough distance between transmitter and quad.

@AngusCox
Copy link
Copy Markdown

AngusCox commented Jan 3, 2020

Same thing happens with X7, using kiss-128x64-lua-scripts-1.0.0.zip (KissCF.lua). Open TX 2.3.2
PIDs - don't save
Rates - don't save
TPA - don't save
Filters - don't save
Alarms - save
VTX - save
D setpoint - save

@lichtl
Copy link
Copy Markdown
Contributor Author

lichtl commented Jan 3, 2020

yes confirmed. on T16 it also cause to go into emergency mode. I currently still try to find out what causes this since function wise all pages share the same generic code to send. I probably have to raise an issue at opentx.

@lichtl
Copy link
Copy Markdown
Contributor Author

lichtl commented Jan 3, 2020

it also seems to be related to crossfire. Frsky SPORT PID change works fine on X9D

@AngusCox
Copy link
Copy Markdown

AngusCox commented Jan 4, 2020

it also seems to be related to crossfire. Frsky SPORT PID change works fine on X9D

Let me know when you have something to test

@fedorcomander
Copy link
Copy Markdown
Collaborator

fedorcomander commented Jan 4, 2020 via email

@AngusCox
Copy link
Copy Markdown

AngusCox commented Jan 4, 2020

I'm trying to add more information for the understanding of the problem.
Talking with @fedorcomander about this issue, and explaining to him that Alarms, VTX and Setpoints Tabs work fine, he told me the following about the difference between them and the other TABs:

"amount of data. pid packet is splitted. vtx - not and if u SEE pids... means FC cuts data to chunks fine... and on the way back - something or wrong with lua or opentx"
"also, crossfire lua uses special crossfire commands TBS made for me, but they should be ok because its TBS stuff."

@lichtl
Copy link
Copy Markdown
Contributor Author

lichtl commented Jan 8, 2020

Hi. did some further looking into it. BF seems to use same CF functionallity. I try to find out later if it is the size. But it looks like there is something with the crossfireTelemetryPush funtion

@awolf78
Copy link
Copy Markdown
Contributor

awolf78 commented Jan 8, 2020

@AngusCox What CRSF version are you running?

@AngusCox
Copy link
Copy Markdown

AngusCox commented Jan 8, 2020

@AngusCox What CRSF version are you running?

@awolf78 CRSF 3.23 on both, TX and RX.

@lichtl
Copy link
Copy Markdown
Contributor Author

lichtl commented Jan 8, 2020

I have same issue on 3.24 and going back to 2.2x it is working. Will hopefully have some more time later to get more idea about the exact root cause in opentx

@AngusCox
Copy link
Copy Markdown

AngusCox commented Jan 8, 2020

I have same issue on 3.24 and going back to 2.2x it is working. Will hopefully have some more time later to get more idea about the exact root cause in opentx

@lichtl thanks for the update!

@lichtl
Copy link
Copy Markdown
Contributor Author

lichtl commented Jan 19, 2020

Ok did some further testing yesterday. This is opentx related and apply to opentx 2.3.x. I've just raised an issue.

opentx/opentx#7310

@lichtl
Copy link
Copy Markdown
Contributor Author

lichtl commented Jan 31, 2020

opentx fix is in latest nightly. Will test this today.

@AngusCox
Copy link
Copy Markdown

I will also try to test it on X7

@lichtl
Copy link
Copy Markdown
Contributor Author

lichtl commented Feb 1, 2020

tested on T16 and X9D+ with current nightly N116. All pages do save. (N116 SD also include the crossfire lua fix from Alex)
Here is the latest version if someone want to test

kiss-128x64-lua-scripts-1.0.0.zip
kiss-212x64-lua-scripts-1.0.0.zip
kiss-480x272-lua-scripts-1.0.0.zip

@AngusCox
Copy link
Copy Markdown

AngusCox commented Feb 1, 2020

tested on T16 and X9D+ with current nightly N116. All pages do save. (N116 SD also include the crossfire lua fix from Alex)
Here is the latest version if someone want to test

kiss-128x64-lua-scripts-1.0.0.zip
kiss-212x64-lua-scripts-1.0.0.zip
kiss-480x272-lua-scripts-1.0.0.zip

Tested on X7 with current nightly N116 (02-01). All pages work perfectly.
Excellent work!

@lichtl lichtl merged commit f8e7eaa into flyduino:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants