Skip to content

Conversation

@HartmannS
Copy link
Contributor

@HartmannS HartmannS commented Oct 5, 2020

Add github workflow.
PR #17 is required.
Fixes were made in commit 387dc1d, but unfortunately the 'custom-standards/Flyeralarm/Sniffs/File/ExceptionMessageSniff.php:32' contains a bug.
The sniff currently uses 'T_CONSTANT_ENCAPSED_STRING' which are all strings and not only exception messages, as the name of the sniff suggests.
That means this sniff prevents all "." and "!" from occurring in strings.
That also means, the current implemented workflow will fail.

@HartmannS
Copy link
Contributor Author

@MichelHartmann MichelHartmann requested a review from domnikl October 5, 2020 11:02
@MichelHartmann
Copy link
Contributor

@vukanac can you review this PR and potentially reanimate if it contains something that is not yet covered in #28?

@vukanac vukanac force-pushed the workflow branch 2 times, most recently from b834c0e to 0c306bd Compare March 23, 2023 12:00
@vukanac
Copy link
Contributor

vukanac commented Mar 23, 2023

I apologise for force push to the wrong origin!
I did checkout to this PR and I didn't expect that pushing will actually push to HartmannS fork! I didn't check remote ref.
The original work is pushed back, but the PR lost track of the contribution.
In any case, I am thankful for contribution and I'll take some ideas from it to implement into new PR.
With new PR open we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants