Skip to content

IN-1729 - Add sniff to make and CI to apply code style check on self #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 24, 2023
Merged

IN-1729 - Add sniff to make and CI to apply code style check on self #29

merged 5 commits into from
Mar 24, 2023

Conversation

@vukanac
Copy link
Contributor

@vukanac vukanac commented Mar 23, 2023 •
edited
Loading

  • Add make sniff
  • Add make sniff-fix
  • Add sniff step in CI
  • Fix code to pass CS check
  • Fix bug in ExceptionMessageSniff to reduce the scope of targets only to classes ending with *Exception,
    -> problem with full body check full instead of only exception message still exists, just now is only in Exceptions.

@vukanac vukanac marked this pull request as draft March 23, 2023 12:12
@vukanac vukanac self-assigned this Mar 23, 2023
@vukanac
Copy link
Contributor Author

vukanac commented Mar 23, 2023 •
edited
Loading

I can confirm the bug with ExceptionMessageSniff still exists as explained in #18 (comment)
It complains on self :) with message:

FILE: /Users/v.vukanac/github/flyeralarm/php-code-validator/custom-standards/Flyeralarm/Sniffs/File/ExceptionMessageSniff.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | Exclamationmarks are not allowed in Exceptionmessages
   |       | (Flyeralarm.File.ExceptionMessage.ExceptionMessageWithInvalidCharacter)
 8 | ERROR | Full stops are not allowed in Exceptionmessages (Flyeralarm.File.ExceptionMessage.ExceptionMessageWithInvalidCharacter)
-------------------------------------------------------------------------------------------------------------------------------------------

and it's because somewhere in the body of the class there are . (line 43) and ! (line 35)!

vukanac referenced this pull request Mar 23, 2023
@vladimir-flyeralarm
IN-1729 - Fix ExceptionMessageSniff to reduce target only to classes …
35dae27 
…ending with *Exception

* The problem with checking all strings in class body instead only of message still exists
* https://github.com/flyeralarm/php-code-validator/pull/29\#issuecomment-1481121548
@vukanac vukanac marked this pull request as ready for review March 23, 2023 13:02
@vukanac
Copy link
Contributor Author

vukanac commented Mar 23, 2023

This PR fixes (or reduces) the problem with the bug explains in #18.
It also incorporates many changes from it.

@vukanac vukanac requested a review from MichelHartmann March 23, 2023 13:03
vukanac
vukanac commented Mar 23, 2023
View reviewed changes
@vukanac vukanac merged commit e2bdd7e into master Mar 24, 2023
@MichelHartmann MichelHartmann deleted the IN-1729-sniff branch March 24, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MichelHartmann MichelHartmann MichelHartmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vukanac vukanac

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vukanac @MichelHartmann @vladimir-flyeralarm