update Go versions#92
Merged
flyingmutant merged 1 commit intoflyingmutant:masterfrom Mar 30, 2026
Merged
Conversation
mxey
force-pushed
the
m.gass/ci_add_go_1_25_and_1_26_xkopnxomxpos
branch
2 times, most recently
from
1e76063 to
d05e03a
Compare
Contributor
Author
|
I guess we could also remove strings_example_test.go, since that only runs on Go < 1.21 |
Owner
Sounds good ( |
mxey
force-pushed
the
m.gass/ci_add_go_1_25_and_1_26_xkopnxomxpos
branch
from
d05e03a to
ecd5255
Compare
Contributor
Author
|
@flyingmutant applied. |
Owner
|
Looks good, please rebase. |
Remove lower than 1.23, because the go.mod requires 1.23. If running on lower versions, the go command just downloaded 1.23 in CI anyway. Add newer versions 1.25 and 1.26 Remove obsolete code for Go < 1.21.
mxey
force-pushed
the
m.gass/ci_add_go_1_25_and_1_26_xkopnxomxpos
branch
from
ecd5255 to
1b279f4
Compare
Contributor
Author
|
@flyingmutant done. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove lower than 1.23, because the go.mod requires 1.23.
If running on lower versions, the go command just downloaded 1.23 in CI anyway.
Add newer versions 1.25 and 1.26