Skip to content

Conversation

@flyingrobots
Copy link
Owner

  • core: split math module into focused submodules
  • Apply suggestions from code review
  • docs: update execution plan + decision log for PR core: split math module into focused submodules #5 (core math split)
  • docs(math): document clamp panic/NaN semantics; clarify EPSILON as degeneracy threshold\ndocs(prng): document zero-state guard in from_seed and panic in next_int\ndocs(quat): expand multiply() docs; add From<[f32;4]> docs\ndocs(vec3): add From<[f32;3]> docs; tighten normalize() docs\ntests(prng): replace brittle golden tests with property-based checks; keep optional golden behind feature flag
  • fix(ci): add optional feature to rmg-core and fix doctest to avoid Vec3 unit constants\n\n- Resolve unexpected_cfgs error under -D warnings in CI\n- Update multiply() doctest to use Vec3::from arrays
  • Update crates/rmg-core/src/math/vec3.rs
  • Update crates/rmg-core/src/math/quat.rs
  • docs(quat): correct composition order in multiply() docs; expand identity() and to_mat4() documentation; clarify to_array() order; add debug asserts to new()\nfix: replace let-chains in motion_executor for toolchain compatibility\nchore: set edition=2021 for rmg-core/ffi/wasm/cli
  • style: reorder math imports and fmt to satisfy rustfmt; adjust rmg-ffi/wasm import order
  • ci: add PRNG golden regression step to CI; fix doc/clippy nits around PRNG_ALGO_VERSION and doc formatting
  • chore(hooks): add .githooks/pre-commit to couple PRNG algorithm/version with golden vector; add Makefile target 'hooks' to install core.hooksPath
  • chore: add .editorconfig and pre-commit rustfmt check (opt-in via make hooks)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 27, 2025

Warning

Rate limit exceeded

@flyingrobots has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 35 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between b1a9383 and 7a7b578.

📒 Files selected for processing (4)
  • .editorconfig (1 hunks)
  • .githooks/pre-commit (1 hunks)
  • docs/decision-log.md (3 hunks)
  • docs/execution-plan.md (1 hunks)
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch echo/hooks-formatting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@flyingrobots flyingrobots merged commit 3d8da97 into main Oct 29, 2025
5 of 6 checks passed
@flyingrobots flyingrobots deleted the echo/hooks-formatting branch October 29, 2025 16:51
@flyingrobots flyingrobots moved this to Todo in Echo Oct 30, 2025
@flyingrobots flyingrobots moved this to Done in Echo Nov 3, 2025
@flyingrobots flyingrobots added this to the M1 – Golden Tests milestone Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants