Document Holmes weslaw assurance PRDs#535
Merged
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 40 minutes and 30 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
📝 WalkthroughWalkthroughAdds a completed 50-slice Holmes ChangesHolmes Weslaw Assurance Planning and Specification Campaign
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
🔍 The Case of Pull Request #535Plain-English Readout
Suggested next actions
📚 Glossary (what the Holmes terms mean)
🕵️ SHA-lock HOLMES full report (click to expand)🕵️ SHA-lock HOLMES Investigation
🔍 Executive Deduction"Watson, after careful examination of the evidence, I deduce..." Weighted Completion: ██████████ 95.0% 🧩 SCS Breakdown
🧪 TCI Breakdown
|
| Component | Risk Share | Points | Count |
|---|---|---|---|
| Drops | 0.0% | 0 | 0 |
| Renames Without Uid | 0.0% | 0 | 0 |
| Add Not Null Without Default | 100.0% | 1 | 1 |
| Non Concurrent Indexes | 0.0% | 0 | 0 |
📊 The Weight of Evidence
"Observe, Watson, how not all features carry equal importance..."
| Element | Weight | Status | Evidence | Strength | Deduction |
|---|---|---|---|---|---|
| schema | 5 | ✅ Exact SQL & tests | test/fixtures/examples/.wesley-cache/shipme-fixture/tests.sql:1-1@e5cfec7 | exact | Elementary! |
🚪 Security & Performance Gates
"Elementary security measures, Watson..."
| Gate | Status | Evidence | Holmes's Ruling |
|---|---|---|---|
| Migration Risk | ✅ | MRI: 10.0% | "Trivial risk" |
| Test Coverage | ✅ | TCI: 90.0% | "Excellent coverage" |
| Sensitive Fields | ✅ | 0 fields | "All secured" |
| Evidence Quality | ✅ | 2 exact · 0 whole-file · 0 coarse | "All 2 citations resolve to exact line spans." |
📋 The Verdict
✅ ELEMENTARY - Ship immediately!
"The evidence is conclusive. No mysteries remain."
Signed and sealed,
- S. Holmes, Consulting Detective
[END OF INVESTIGATION FOR COMMIT e5cfec7]
🧵 Command Run
- Run ID: run-5fd81479-8680-4b12-8fe8-99c62170daf4
- Transmutation: holmes-investigate
- Command: investigate
- Status: completed
- Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger
🩺 Dr. WATSON full report (click to expand)
🩺 Dr. Watson's Independent Verification Report
Medical Examination of Evidence
- Examination Date: 2026-05-27T01:38:16.007Z
- Patient SHA: e5cfec7
🔬 Citation Verification
"Let me examine each piece of evidence independently..."
- Citations Examined: 2
- Verified: 0 ✅
- Failed: 0 ❌
- Unable to Verify: 2
- Exact Subrange Citations: 0
- Whole-file Citations: 0
- Coarse Citations: 0
- Evidence Trust: missing
- Trust Note: No evidence citations were available for trust analysis.
Verification Rate: 0.0%
📊 Mathematical Verification
"I shall recalculate Holmes's arithmetic..."
Holmes claimed SCS: 95.0%
Watson calculates: 100.0%
Difference:
🔍 Consistency Analysis
"Checking for contradictions in Holmes's deductions..."
✅ No logical inconsistencies detected
🩺 Dr. Watson's Medical Opinion
VERIFICATION: CONCERNS NOTED
"While Holmes's methods are generally sound, I have noted some"
"discrepancies that warrant further investigation. No evidence citations were available for trust analysis."
Respectfully submitted,
- Dr. J. Watson, M.D.
Medical Examiner & Verification Specialist
🧵 Command Run
- Run ID: run-5a838f7e-6e3d-41a3-bb74-51fe50b43275
- Transmutation: watson-verify
- Command: verify
- Status: completed
- Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger
🔮 Professor MORIARTY full report (click to expand)
🧠 Professor Moriarty's Temporal Predictions
The Mathematics of Inevitability
- Analysis Date: 2026-05-27T01:38:49.578Z
INSUFFICIENT DATA
"I require at least two data points to predict the future."
"Run Wesley generate multiple times to build history."
🧵 Command Run
- Run ID: run-1cc968d1-55cf-4192-867b-460e6199401d
- Transmutation: moriarty-predict
- Command: predict
- Status: completed
- Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger
Machine-readable reports: holmes-report.json · watson-report.json · moriarty-report.json (see workflow artifacts).
Filed at 221B Repository Street
Owner
Author
|
@codex Self-code-review findings for PR #535.
Issue count: P0 0, P1 0, P2 0, P3 0, P4 1, P5 1. Checks consulted: clean worktree, |
|
Summary
Testing
|
Owner
Author
|
Resolved both self-review findings in
Validation: |
flyingrobots
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (14)
docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-029-mcp-law-policy-tool.md (1)
116-116:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMarkdown table appears incomplete.
The Non-Functional Testing table ends without a closing blank line. Ensure proper markdown rendering by adding a blank line after the table.
📝 Proposed fix
| Accessibility | Response includes text profile and rule descriptions. | Schema contract test. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-029-mcp-law-policy-tool.md` at line 116, The Markdown table under the "Non-Functional Testing" section is not followed by a blank line, which breaks rendering; open the "Non-Functional Testing" table in HLAW-029-mcp-law-policy-tool.md (search for the "Non-Functional Testing" header) and add a single blank line immediately after the table closure so the table renders correctly.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-033-law-coverage-threshold-policy.md (1)
113-113:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMarkdown table appears incomplete.
The Non-Functional Testing table ends without a closing blank line. Ensure proper markdown rendering by adding a blank line after the table.
📝 Proposed fix
| Accessibility | Decision output includes text status, actual percentage, and threshold. | Contract test decision fields. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-033-law-coverage-threshold-policy.md` at line 113, The "Non-Functional Testing" markdown table in HLAW-033-law-coverage-threshold-policy.md is missing a trailing blank line which breaks rendering; open the "Non-Functional Testing" section, locate the end of the table (the final table row/pipe-delimited line) and add a single blank line after it to terminate the table properly so Markdown renders the following content correctly.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-027-mcp-law-evidence-resources.md (1)
113-113:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMarkdown table appears incomplete.
The Non-Functional Testing table ends abruptly without a closing blank line. Markdown tables should be followed by a blank line to ensure proper rendering.
📝 Proposed fix
| Accessibility | Resource summaries include text role and status fields. | Schema contract test. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-027-mcp-law-evidence-resources.md` at line 113, The Markdown table under the "Non-Functional Testing" section is incomplete and missing the required trailing blank line; update the "Non-Functional Testing" table by ensuring all table rows and the header/footer separators are present and then add a blank line after the table (i.e., a single empty line following the final table row) so the table renders correctly in Markdown.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-034-law-assurance-suppression-policy.md (1)
116-116:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMarkdown table appears incomplete.
The Non-Functional Testing table ends without a closing blank line. Add a blank line after the table to ensure proper markdown rendering.
📝 Proposed fix
| Accessibility | Suppressed state includes text labels and reason references. | Contract test report fields. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-034-law-assurance-suppression-policy.md` at line 116, The Markdown Non-Functional Testing table in HLAW-034-law-assurance-suppression-policy.md is missing the required closing blank line which can break rendering; open the "Non-Functional Testing" section (look for the table markup under that heading) and add a single blank line after the table's final row to ensure proper Markdown rendering.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-028-mcp-explain-law-finding-tool.md (1)
114-114:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMarkdown table appears incomplete.
The Non-Functional Testing table ends without a closing blank line. Add a blank line after the table to ensure proper markdown rendering.
📝 Proposed fix
| Accessibility | Explanation includes plain text summary and next-action fields. | Schema contract test. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-028-mcp-explain-law-finding-tool.md` at line 114, The "Non-Functional Testing" markdown table in HLAW-028-mcp-explain-law-finding-tool.md is not followed by a blank line which can break rendering; open the "Non-Functional Testing" section and add a single blank line immediately after the table's final row so the table is properly terminated and subsequent content renders correctly.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-030-agent-safe-law-summary.md (1)
114-114:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMarkdown table appears incomplete.
The Non-Functional Testing table ends without a closing blank line. Add a blank line after the table for proper markdown rendering.
📝 Proposed fix
| Accessibility | Summary uses explicit text status and next-inspection labels. | Schema contract test. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-030-agent-safe-law-summary.md` at line 114, The Markdown "Non-Functional Testing" table in HLAW-030-agent-safe-law-summary.md is missing the closing blank line which can break rendering; open the "Non-Functional Testing" section, locate the Markdown table block, and add a single blank line immediately after the table (after the final table row and any trailing pipes) to ensure the table is properly terminated and the document renders correctly.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-031-law-assurance-policy-schema.md (1)
115-115:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMarkdown table appears incomplete.
The Non-Functional Testing table ends without a closing blank line. Ensure proper markdown rendering by adding a blank line after the table.
📝 Proposed fix
| Accessibility | Policy diagnostics include code, profile, and field path as text. | Snapshot diagnostics. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-031-law-assurance-policy-schema.md` at line 115, The Markdown table under the "Non-Functional Testing" section in HLAW-031-law-assurance-policy-schema.md is not followed by a blank line; add a single blank line immediately after the end of that table (the row/pipe block under the "Non-Functional Testing" section) so the table closes correctly and renders properly in Markdown.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-032-law-severity-mapping-policy.md (1)
112-112:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMarkdown table appears incomplete.
The Non-Functional Testing table ends without a closing blank line. Add a blank line after the table to ensure proper markdown rendering.
📝 Proposed fix
| Accessibility | Mapped severity includes text label and original event kind. | Contract test mapped fields. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-032-law-severity-mapping-policy.md` at line 112, Add a single blank line immediately after the "Non-Functional Testing" markdown table so the table is terminated with an empty line (ensure the table ends with a trailing newline), then re-render to confirm proper markdown formatting in HLAW-032-law-severity-mapping-policy.md.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-040-law-assurance-performance-budget.md (1)
119-119:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winDocument appears truncated.
The Non-Functional Testing table ends abruptly at line 119 without a closing pipe character or final newline. Verify that no content was accidentally omitted.
📝 Suggested completion
| Accessibility | Benchmark failure reports include text component names and values. | Snapshot benchmark report. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-040-law-assurance-performance-budget.md` at line 119, The Non-Functional Testing table in HLAW-040-law-assurance-performance-budget is truncated (ends abruptly in the "Non-Functional Testing" table around the shown breakpoint); reopen that table block, add the missing trailing pipe character(s) and final newline, and restore any omitted rows or closing table markdown so the table is syntactically complete—review the section after the last complete row and reinsert any missing cells/rows and closing pipes to match the expected table header/column count.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-035-law-assurance-audit-witness.md (1)
116-116:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winDocument appears truncated.
The Non-Functional Testing table at line 116 ends abruptly without a closing pipe character or final newline. Verify that no content was accidentally omitted.
📝 Suggested completion
| Accessibility | Witness is machine-readable JSON with text status fields for audit tools. | JSON Schema validation and snapshot. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-035-law-assurance-audit-witness.md` at line 116, The Non-Functional Testing table in HLAW-035-law-assurance-audit-witness.md is truncated (the table row at "Non-Functional Testing" ends without a trailing pipe and final newline); reopen the document, restore or re-add the missing table cell delimiters and a final newline, ensure the table header/footer (pipes) are balanced, and confirm no rows or explanatory text for Non-Functional Testing were omitted—if content was removed, restore the intended rows/notes so the table renders correctly.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-039-law-assurance-concurrency-and-idempotence.md (1)
118-118:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winDocument appears truncated.
The Non-Functional Testing table ends abruptly at line 118 without a closing pipe character or final newline. Verify that no content was accidentally omitted.
📝 Suggested completion
| Accessibility | Retry/collision diagnostics include text reason and remediation. | Snapshot diagnostics. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-039-law-assurance-concurrency-and-idempotence.md` at line 118, The Non-Functional Testing table in HLAW-039-law-assurance-concurrency-and-idempotence.md is truncated at line 118 and missing the closing pipe/newline and possibly final rows; reopen the document's "Non-Functional Testing" table, restore or reconstruct any omitted rows and ensure each table row ends with a pipe and the table ends with a blank newline; verify the header, separator (-----|-----), and final closing pipe are present and that any subsequent paragraphs or sections after the table (e.g., conclusions or test-case references) are intact.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-038-law-assurance-fake-clock-and-ports.md (1)
118-118:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winDocument appears truncated.
The Non-Functional Testing table ends abruptly at line 118 without a closing pipe character or final newline. Verify that no content was accidentally omitted.
📝 Suggested completion
| Accessibility | Fake-rendered text snapshots include the same status labels as production renderers. | Snapshot comparison. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-038-law-assurance-fake-clock-and-ports.md` at line 118, The Non-Functional Testing table in the document is truncated and missing the trailing pipe and final newline; open the document, locate the "Non-Functional Testing" table, restore the missing closing pipe and any cut-off row content (ensure each table row ends with '|' and the table has a final newline), and scan surrounding text to confirm no additional lines were accidentally omitted so the table and subsequent sections render correctly.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-036-law-assurance-golden-fixture-corpus.md (1)
123-123:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winDocument appears truncated.
The Non-Functional Testing table ends abruptly at line 123 without a closing pipe character or final newline. Verify that no content was accidentally omitted.
📝 Suggested completion
| Accessibility | Golden Markdown snapshots include headings and text statuses for screen-reader-friendly review. | Markdown snapshot assertions. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-036-law-assurance-golden-fixture-corpus.md` at line 123, The "Non-Functional Testing" markdown table is truncated (missing the closing pipe and final newline) — open the document, locate the "Non-Functional Testing" table heading and the table rows, restore the missing trailing pipe characters and add a final newline/blank line after the table, and verify no rows or subsequent sections were accidentally deleted (reinsert any omitted cells/rows so the table columns align); then render-check the markdown to ensure the table displays correctly.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-037-law-assurance-negative-fixture-corpus.md (1)
118-118:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winDocument appears truncated.
The Non-Functional Testing table ends abruptly at line 118 without a closing pipe character or final newline. Verify that no content was accidentally omitted.
📝 Suggested completion
| Accessibility | Diagnostic snapshots include code, artifact role, and remediation text. | Snapshot assertions. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-037-law-assurance-negative-fixture-corpus.md` at line 118, The "Non-Functional Testing" Markdown table in HLAW-037-law-assurance-negative-fixture-corpus.md is truncated (missing the closing pipe/row terminator and final newline); open that section, restore any missing rows or cells, ensure each table row ends with a trailing pipe (|) and that the table has a final newline after the last row, and validate the table header/align row (---) and content rows are syntactically correct so the table renders fully.
🧹 Nitpick comments (13)
docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-006-weslaw-artifact-locator.md (1)
126-126: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line per standard Markdown conventions.
📝 Proposed fix
| Accessibility | Diagnostics must name role, original reference, and normalized path when safe. | Snapshot text diagnostics with color disabled. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-006-weslaw-artifact-locator.md` at line 126, The file HLAW-006-weslaw-artifact-locator.md is missing a trailing newline; open the document (docs/design/.../HLAW-006-weslaw-artifact-locator.md) and add a single blank line at the end of the file so it ends with a newline character, then save and commit the change.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-008-semantic-change-finding.md (1)
126-126: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line per standard Markdown conventions.
📝 Proposed fix
| Accessibility | Each finding must include text severity and summary fields for non-color renderers. | Contract test required text fields. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-008-semantic-change-finding.md` at line 126, Add a single trailing newline to the end of the Markdown file HLAW-008-semantic-change-finding.md so the file ends with a blank line per standard Markdown conventions; open the file and ensure there is one final newline character after the last line of content, then save the file.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-007-law-evidence-validation-result.md (1)
126-126: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line per standard Markdown conventions.
📝 Proposed fix
| Accessibility | Text diagnostics must include code and remediation hint without relying on color. | Snapshot terminal text with color disabled. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-007-law-evidence-validation-result.md` at line 126, Add a trailing newline to the end of the markdown file HLAW-007-law-evidence-validation-result.md so the file finishes with a blank line (i.e., ensure the final character is a newline), following standard Markdown conventions.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-009-law-coverage-gate-decision.md (1)
125-125: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line per standard Markdown conventions.
📝 Proposed fix
| Accessibility | Gate decisions must include text status and rationale independent of color. | Contract test status, summary, and remediation fields. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-009-law-coverage-gate-decision.md` at line 125, Add a single trailing newline to the end of the Markdown document HLAW-009-law-coverage-gate-decision.md so the file ends with a blank line; open the file and ensure the final character is a newline (i.e., insert one more line break after the last line) and save.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-010-bundle-traceability-gate-decision.md (1)
126-126: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line per standard Markdown conventions.
📝 Proposed fix
| Accessibility | Mismatch output must name expected and actual hash values in text. | Snapshot text gate summaries with color disabled. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-010-bundle-traceability-gate-decision.md` at line 126, This PRD file (HLAW-010-bundle-traceability-gate-decision) is missing a trailing newline; open the document and add a single blank line at the very end of the file (ensure the file ends with a '\n') so the file conforms to standard Markdown/end-of-file conventions.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-024-github-law-evidence-links.md (1)
113-113: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line for consistency with common text file conventions.
📝 Proposed fix
| Accessibility | Link labels describe destination role, not "click here". | Snapshot link labels. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-024-github-law-evidence-links.md` at line 113, Add a single trailing newline to the end of the file so it ends with a blank line (ensure the file's final character is a newline / newline at EOF); open the file in an editor or adjust your commit to append a newline and re-run lint/format checks to confirm the change is saved.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-025-github-law-override-controls.md (1)
116-116: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line for consistency with common text file conventions.
📝 Proposed fix
| Accessibility | Acknowledged state includes text labels and reason reference. | Contract test summary fields. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-025-github-law-override-controls.md` at line 116, Add a single trailing newline to the end of the document HLAW-025-github-law-override-controls.md so the file ends with a blank line; open the file and ensure there is one final empty line character after the last line of content and save the file.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-026-mcp-assess-weslaw-bundle-tool.md (1)
116-116: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line for consistency with common text file conventions.
📝 Proposed fix
| Accessibility | Response includes text status fields agents can quote directly. | Schema contract test. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-026-mcp-assess-weslaw-bundle-tool.md` at line 116, Add a single trailing newline character to the end of the document HLAW-026-mcp-assess-weslaw-bundle-tool.md so the file ends with a blank line; open the file and ensure the last line is terminated with a newline (no other content changes).docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-019-law-assurance-artifact-writer.md (1)
121-121: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line for consistency with common text file conventions and to avoid potential diff noise.
📝 Proposed fix
| Accessibility | Rendered text and Markdown artifacts preserve headings and status labels. | Snapshot generated outputs. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-019-law-assurance-artifact-writer.md` at line 121, Add a single trailing newline to the end of the document HLAW-019-law-assurance-artifact-writer.md so the file ends with a blank line; open the file, place the cursor after the last character, insert one newline (ensure no extra whitespace lines), save, and commit the change.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-022-github-law-gate-check-summary.md (1)
112-112: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line for consistency with common text file conventions.
📝 Proposed fix
| Accessibility | State label and primary reason are text fields. | Contract test non-color summary fields. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-022-github-law-gate-check-summary.md` at line 112, Add a single trailing newline to the end of HLAW-022-github-law-gate-check-summary.md so the file ends with a blank line (ensure the final character is a newline, not EOF directly), commit the change to maintain standard text-file convention.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-023-github-law-finding-annotations.md (1)
115-115: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line for consistency with common text file conventions.
📝 Proposed fix
| Accessibility | Annotation messages include text severity and law id. | Contract test annotation fields. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-023-github-law-finding-annotations.md` at line 115, The file HLAW-023-github-law-finding-annotations.md is missing a trailing newline; open that markdown file and add a single blank line (newline character) at the end of the file so it ends with an empty line, save and commit the change to satisfy the EOF newline convention.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-021-github-law-assurance-comment.md (1)
117-117: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line for consistency with common text file conventions.
📝 Proposed fix
| Accessibility | Comment uses headings, tables, and text statuses independent of color. | Markdown snapshot review. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-021-github-law-assurance-comment.md` at line 117, Add a single trailing newline to the end of the file so it ends with a blank line (i.e., ensure the final character is a newline); open HLAW-021-github-law-assurance-comment.md and insert one empty line at the end, then save/commit the change.docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-020-law-assurance-exit-code-policy.md (1)
117-117: ⚡ Quick winAdd trailing newline at end of file.
The file should end with a blank line for consistency with common text file conventions.
📝 Proposed fix
| Accessibility | CLI text always names the exit category and primary reason. | Snapshot stderr/stdout with color disabled. | +🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-020-law-assurance-exit-code-policy.md` at line 117, Add a single trailing newline at the end of the HLAW-020-law-assurance-exit-code-policy.md document so the file ends with one blank line (ensure there is exactly one newline character after the last line of content); open the file and append a final newline before saving/committing so tools and editors treat it as a proper text file EOF.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-027-mcp-law-evidence-resources.md`:
- Line 113: The Markdown table under the "Non-Functional Testing" section is
incomplete and missing the required trailing blank line; update the
"Non-Functional Testing" table by ensuring all table rows and the header/footer
separators are present and then add a blank line after the table (i.e., a single
empty line following the final table row) so the table renders correctly in
Markdown.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-028-mcp-explain-law-finding-tool.md`:
- Line 114: The "Non-Functional Testing" markdown table in
HLAW-028-mcp-explain-law-finding-tool.md is not followed by a blank line which
can break rendering; open the "Non-Functional Testing" section and add a single
blank line immediately after the table's final row so the table is properly
terminated and subsequent content renders correctly.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-029-mcp-law-policy-tool.md`:
- Line 116: The Markdown table under the "Non-Functional Testing" section is not
followed by a blank line, which breaks rendering; open the "Non-Functional
Testing" table in HLAW-029-mcp-law-policy-tool.md (search for the
"Non-Functional Testing" header) and add a single blank line immediately after
the table closure so the table renders correctly.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-030-agent-safe-law-summary.md`:
- Line 114: The Markdown "Non-Functional Testing" table in
HLAW-030-agent-safe-law-summary.md is missing the closing blank line which can
break rendering; open the "Non-Functional Testing" section, locate the Markdown
table block, and add a single blank line immediately after the table (after the
final table row and any trailing pipes) to ensure the table is properly
terminated and the document renders correctly.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-031-law-assurance-policy-schema.md`:
- Line 115: The Markdown table under the "Non-Functional Testing" section in
HLAW-031-law-assurance-policy-schema.md is not followed by a blank line; add a
single blank line immediately after the end of that table (the row/pipe block
under the "Non-Functional Testing" section) so the table closes correctly and
renders properly in Markdown.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-032-law-severity-mapping-policy.md`:
- Line 112: Add a single blank line immediately after the "Non-Functional
Testing" markdown table so the table is terminated with an empty line (ensure
the table ends with a trailing newline), then re-render to confirm proper
markdown formatting in HLAW-032-law-severity-mapping-policy.md.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-033-law-coverage-threshold-policy.md`:
- Line 113: The "Non-Functional Testing" markdown table in
HLAW-033-law-coverage-threshold-policy.md is missing a trailing blank line which
breaks rendering; open the "Non-Functional Testing" section, locate the end of
the table (the final table row/pipe-delimited line) and add a single blank line
after it to terminate the table properly so Markdown renders the following
content correctly.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-034-law-assurance-suppression-policy.md`:
- Line 116: The Markdown Non-Functional Testing table in
HLAW-034-law-assurance-suppression-policy.md is missing the required closing
blank line which can break rendering; open the "Non-Functional Testing" section
(look for the table markup under that heading) and add a single blank line after
the table's final row to ensure proper Markdown rendering.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-035-law-assurance-audit-witness.md`:
- Line 116: The Non-Functional Testing table in
HLAW-035-law-assurance-audit-witness.md is truncated (the table row at
"Non-Functional Testing" ends without a trailing pipe and final newline); reopen
the document, restore or re-add the missing table cell delimiters and a final
newline, ensure the table header/footer (pipes) are balanced, and confirm no
rows or explanatory text for Non-Functional Testing were omitted—if content was
removed, restore the intended rows/notes so the table renders correctly.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-036-law-assurance-golden-fixture-corpus.md`:
- Line 123: The "Non-Functional Testing" markdown table is truncated (missing
the closing pipe and final newline) — open the document, locate the
"Non-Functional Testing" table heading and the table rows, restore the missing
trailing pipe characters and add a final newline/blank line after the table, and
verify no rows or subsequent sections were accidentally deleted (reinsert any
omitted cells/rows so the table columns align); then render-check the markdown
to ensure the table displays correctly.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-037-law-assurance-negative-fixture-corpus.md`:
- Line 118: The "Non-Functional Testing" Markdown table in
HLAW-037-law-assurance-negative-fixture-corpus.md is truncated (missing the
closing pipe/row terminator and final newline); open that section, restore any
missing rows or cells, ensure each table row ends with a trailing pipe (|) and
that the table has a final newline after the last row, and validate the table
header/align row (---) and content rows are syntactically correct so the table
renders fully.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-038-law-assurance-fake-clock-and-ports.md`:
- Line 118: The Non-Functional Testing table in the document is truncated and
missing the trailing pipe and final newline; open the document, locate the
"Non-Functional Testing" table, restore the missing closing pipe and any cut-off
row content (ensure each table row ends with '|' and the table has a final
newline), and scan surrounding text to confirm no additional lines were
accidentally omitted so the table and subsequent sections render correctly.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-039-law-assurance-concurrency-and-idempotence.md`:
- Line 118: The Non-Functional Testing table in
HLAW-039-law-assurance-concurrency-and-idempotence.md is truncated at line 118
and missing the closing pipe/newline and possibly final rows; reopen the
document's "Non-Functional Testing" table, restore or reconstruct any omitted
rows and ensure each table row ends with a pipe and the table ends with a blank
newline; verify the header, separator (-----|-----), and final closing pipe are
present and that any subsequent paragraphs or sections after the table (e.g.,
conclusions or test-case references) are intact.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-040-law-assurance-performance-budget.md`:
- Line 119: The Non-Functional Testing table in
HLAW-040-law-assurance-performance-budget is truncated (ends abruptly in the
"Non-Functional Testing" table around the shown breakpoint); reopen that table
block, add the missing trailing pipe character(s) and final newline, and restore
any omitted rows or closing table markdown so the table is syntactically
complete—review the section after the last complete row and reinsert any missing
cells/rows and closing pipes to match the expected table header/column count.
---
Nitpick comments:
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-006-weslaw-artifact-locator.md`:
- Line 126: The file HLAW-006-weslaw-artifact-locator.md is missing a trailing
newline; open the document (docs/design/.../HLAW-006-weslaw-artifact-locator.md)
and add a single blank line at the end of the file so it ends with a newline
character, then save and commit the change.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-007-law-evidence-validation-result.md`:
- Line 126: Add a trailing newline to the end of the markdown file
HLAW-007-law-evidence-validation-result.md so the file finishes with a blank
line (i.e., ensure the final character is a newline), following standard
Markdown conventions.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-008-semantic-change-finding.md`:
- Line 126: Add a single trailing newline to the end of the Markdown file
HLAW-008-semantic-change-finding.md so the file ends with a blank line per
standard Markdown conventions; open the file and ensure there is one final
newline character after the last line of content, then save the file.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-009-law-coverage-gate-decision.md`:
- Line 125: Add a single trailing newline to the end of the Markdown document
HLAW-009-law-coverage-gate-decision.md so the file ends with a blank line; open
the file and ensure the final character is a newline (i.e., insert one more line
break after the last line) and save.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-010-bundle-traceability-gate-decision.md`:
- Line 126: This PRD file (HLAW-010-bundle-traceability-gate-decision) is
missing a trailing newline; open the document and add a single blank line at the
very end of the file (ensure the file ends with a '\n') so the file conforms to
standard Markdown/end-of-file conventions.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-019-law-assurance-artifact-writer.md`:
- Line 121: Add a single trailing newline to the end of the document
HLAW-019-law-assurance-artifact-writer.md so the file ends with a blank line;
open the file, place the cursor after the last character, insert one newline
(ensure no extra whitespace lines), save, and commit the change.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-020-law-assurance-exit-code-policy.md`:
- Line 117: Add a single trailing newline at the end of the
HLAW-020-law-assurance-exit-code-policy.md document so the file ends with one
blank line (ensure there is exactly one newline character after the last line of
content); open the file and append a final newline before saving/committing so
tools and editors treat it as a proper text file EOF.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-021-github-law-assurance-comment.md`:
- Line 117: Add a single trailing newline to the end of the file so it ends with
a blank line (i.e., ensure the final character is a newline); open
HLAW-021-github-law-assurance-comment.md and insert one empty line at the end,
then save/commit the change.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-022-github-law-gate-check-summary.md`:
- Line 112: Add a single trailing newline to the end of
HLAW-022-github-law-gate-check-summary.md so the file ends with a blank line
(ensure the final character is a newline, not EOF directly), commit the change
to maintain standard text-file convention.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-023-github-law-finding-annotations.md`:
- Line 115: The file HLAW-023-github-law-finding-annotations.md is missing a
trailing newline; open that markdown file and add a single blank line (newline
character) at the end of the file so it ends with an empty line, save and commit
the change to satisfy the EOF newline convention.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-024-github-law-evidence-links.md`:
- Line 113: Add a single trailing newline to the end of the file so it ends with
a blank line (ensure the file's final character is a newline / newline at EOF);
open the file in an editor or adjust your commit to append a newline and re-run
lint/format checks to confirm the change is saved.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-025-github-law-override-controls.md`:
- Line 116: Add a single trailing newline to the end of the document
HLAW-025-github-law-override-controls.md so the file ends with a blank line;
open the file and ensure there is one final empty line character after the last
line of content and save the file.
In
`@docs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-026-mcp-assess-weslaw-bundle-tool.md`:
- Line 116: Add a single trailing newline character to the end of the document
HLAW-026-mcp-assess-weslaw-bundle-tool.md so the file ends with a blank line;
open the file and ensure the last line is terminated with a newline (no other
content changes).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 06a829fa-1565-4ef2-a327-d993d4e6f916
📒 Files selected for processing (54)
docs/BEARING.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/holmes-weslaw-assurance-prd-test-plan.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-001-holmes-law-evidence-bundle.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-002-law-diff-ingest-port.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-003-law-coverage-ingest-port.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-004-law-capability-ingest-port.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-005-contract-bundle-manifest-ingest-port.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-006-weslaw-artifact-locator.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-007-law-evidence-validation-result.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-008-semantic-change-finding.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-009-law-coverage-gate-decision.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-010-bundle-traceability-gate-decision.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-011-law-assurance-report-document.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-012-law-diff-report-section.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-013-law-coverage-report-section.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-014-law-capability-report-section.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-015-bundle-provenance-report-section.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-016-holmes-weslaw-validate-cli.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-017-holmes-weslaw-assess-cli.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-018-holmes-weslaw-report-cli.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-019-law-assurance-artifact-writer.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-020-law-assurance-exit-code-policy.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-021-github-law-assurance-comment.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-022-github-law-gate-check-summary.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-023-github-law-finding-annotations.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-024-github-law-evidence-links.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-025-github-law-override-controls.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-026-mcp-assess-weslaw-bundle-tool.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-027-mcp-law-evidence-resources.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-028-mcp-explain-law-finding-tool.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-029-mcp-law-policy-tool.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-030-agent-safe-law-summary.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-031-law-assurance-policy-schema.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-032-law-severity-mapping-policy.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-033-law-coverage-threshold-policy.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-034-law-assurance-suppression-policy.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-035-law-assurance-audit-witness.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-036-law-assurance-golden-fixture-corpus.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-037-law-assurance-negative-fixture-corpus.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-038-law-assurance-fake-clock-and-ports.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-039-law-assurance-concurrency-and-idempotence.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-040-law-assurance-performance-budget.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-041-legacy-holmes-law-evidence-mapping.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-042-holmes-workflow-weslaw-integration.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-043-rust-holmes-crate-scaffold.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-044-transitional-holmes-cli-aliases.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-045-law-assurance-operator-docs.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-046-law-assurance-schema-versioning.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-047-law-assurance-artifact-retention.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-048-law-assurance-end-to-end-workflow.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-049-law-assurance-release-gate-rollout.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/HLAW-050-holmes-weslaw-assurance-closeout.mddocs/design/0020-holmes-weslaw-assurance-prd-test-plan/prds/README.mddocs/design/README.md
Owner
Author
|
@codex Self-review against
Summary: 9 findings total: P1=1, P2=2, P3=2, P4=1, P5=3. Local pre-checks passed before review: clean worktree and |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
crates/wesley-holmes/src/ports/mod.rs (1)
103-106: ⚡ Quick winKeep in-memory writes readable from the same store.
Line 105 and Line 123 only update
writes; follow-up reads through load/filesystem ports won’t see newly written bytes.Suggested fix
impl ArtifactWritePort for InMemoryArtifactStore { fn write_artifact(&mut self, path: &str, bytes: &[u8]) -> HolmesResult<()> { - self.writes.insert(path.to_owned(), bytes.to_vec()); + let data = bytes.to_vec(); + self.writes.insert(path.to_owned(), data.clone()); + self.artifacts.insert(path.to_owned(), data); Ok(()) } } impl FilesystemPort for InMemoryArtifactStore { @@ fn write_workspace_file(&mut self, path: &str, bytes: &[u8]) -> HolmesResult<()> { - self.writes.insert(path.to_owned(), bytes.to_vec()); + let data = bytes.to_vec(); + self.writes.insert(path.to_owned(), data.clone()); + self.artifacts.insert(path.to_owned(), data); Ok(()) } }Also applies to: 122-124
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/wesley-holmes/src/ports/mod.rs` around lines 103 - 106, The in-memory writer (InMemoryArtifactStore::write_artifact) only updates the writes map so subsequent reads via the load/filesystem ports don't see new data; update write_artifact to insert the same bytes into the in-memory read stores used by the load/filesystem ports (e.g., the maps named writes plus the read-backed maps such as files and/or filesystem) so the newly written bytes are available to read; modify InMemoryArtifactStore::write_artifact to insert path.to_owned() -> bytes.to_vec() into both writes and the in-memory read map(s) (the same maps used by load_artifact/read methods).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/wesley-holmes/src/application/artifact_locator.rs`:
- Around line 58-95: In WeslawArtifactLocator::resolve, the code currently lets
backslashes live inside Component::Normal and thus emit them into
ResolvedArtifactPath.workspace_relative; before calling Path::new or before
normalization, detect any backslash characters in the input path string and
return an ArtifactLocatorError (e.g. "artifact path must use '/' separators" or
similar) to enforce the "/"-separator contract, or alternatively normalize by
converting backslashes to forward slashes before further processing; update
error text and ensure the check uses the same ArtifactLocatorError type so
callers see a clear, consistent error when a '\' is present.
In `@crates/wesley-holmes/src/domain/versioning.rs`:
- Around line 152-155: The code currently falls back to constructing a
VersionRequirement when self.requirement(family) is None, which silently accepts
unspecified registry families; change this to fail closed by returning an error
when the requirement is missing instead of calling VersionRequirement::new.
Replace the unwrap_or_else call on self.requirement(family) so the surrounding
function returns a Result and propagates an Err (with a clear message
referencing the family and parsed version) when None is found; update callers to
handle the Result (or use the ? operator) so missing registry entries cause a
hard failure rather than default acceptance.
---
Nitpick comments:
In `@crates/wesley-holmes/src/ports/mod.rs`:
- Around line 103-106: The in-memory writer
(InMemoryArtifactStore::write_artifact) only updates the writes map so
subsequent reads via the load/filesystem ports don't see new data; update
write_artifact to insert the same bytes into the in-memory read stores used by
the load/filesystem ports (e.g., the maps named writes plus the read-backed maps
such as files and/or filesystem) so the newly written bytes are available to
read; modify InMemoryArtifactStore::write_artifact to insert path.to_owned() ->
bytes.to_vec() into both writes and the in-memory read map(s) (the same maps
used by load_artifact/read methods).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e40e491b-64d8-40a8-8e3c-5a08edfeee3a
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (20)
CHANGELOG.mdCargo.tomlcrates/wesley-holmes/Cargo.tomlcrates/wesley-holmes/README.mdcrates/wesley-holmes/src/adapters/mod.rscrates/wesley-holmes/src/application/artifact_locator.rscrates/wesley-holmes/src/application/mod.rscrates/wesley-holmes/src/domain/diagnostic.rscrates/wesley-holmes/src/domain/evidence.rscrates/wesley-holmes/src/domain/mod.rscrates/wesley-holmes/src/domain/versioning.rscrates/wesley-holmes/src/lib.rscrates/wesley-holmes/src/ports/mod.rscrates/wesley-holmes/src/reporting/mod.rscrates/wesley-holmes/tests/architecture.rscrates/wesley-holmes/tests/foundation.rsdocs/ARCHITECTURE.mddocs/BEARING.mddocs/GUIDE.mddocs/design/README.md
✅ Files skipped from review due to trivial changes (7)
- crates/wesley-holmes/src/adapters/mod.rs
- crates/wesley-holmes/src/reporting/mod.rs
- docs/design/README.md
- CHANGELOG.md
- Cargo.toml
- docs/GUIDE.md
- docs/ARCHITECTURE.md
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/BEARING.md
Summary
Committed: Testing
|
Owner
Author
|
@coderabbitai review please Resolved review feedback in
Validation:
Stale/global CodeRabbit doc remarks checked: the referenced HLAW non-functional tables are complete, and the listed HLAW PRD files now end with trailing newlines. |
|
🐇 ✨ ✅ Actions performedReview triggered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
weslawassurance PRD/test-plan campaign.HIMP-*slice referencing the completed HLAW design docs it implements.Completed Planning Slices
Implementation Bearing
Validation
git diff --checknode scripts/check-doc-links.mjsnode scripts/check-doc-truth.mjsnode scripts/lint-docs-whitespace.mjspnpm run preflightNotes
This remains planning and QA specification work only. It does not implement Holmes law assurance runtime code, does not change Wesley
weslawsemantics, and does not touch sibling repos.Summary by CodeRabbit
Documentation
New Component
Project Docs