start implementation of UPnP-gw-DeviceProtection-V1#35
Closed
cclecle wants to merge 6 commits intoflyte:developfrom
Closed
start implementation of UPnP-gw-DeviceProtection-V1#35cclecle wants to merge 6 commits intoflyte:developfrom
cclecle wants to merge 6 commits intoflyte:developfrom
Conversation
added 6 commits
January 6, 2022 13:32
…-Service compliance.
- add certificate option - update Readme
- add certificate option - update Readme
…pclient.git into feature/DeviceProtection # Conflicts: # README.md
- Subclassing HTTP / requests to get peer_certificate back from lower levels (WIP)
Owner
|
Thanks for the PR. The core ideas here (SSL self-signed cert support, fixed SSDP port) are useful. The implementation has some issues though (debug prints, HTTP method changes, deep urllib3 subclassing) and the codebase has moved on since 2022, so this PR can't be merged as-is. Closing this, but I've opened #49 to track adding SSL/self-signed cert support properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch will allow connection to SSL device with self-signed certificate, as explained in UPnP-gw-DeviceProtection-V1-Service specifications.
Its working but will raise a few warning from sublibrary (because of self-signed warning).
Next step: