Skip to content

remove gRPC PHP extension from build#32

Merged
itsrafsanjani merged 1 commit intoflywp:mainfrom
ma-04:chore/remove_grpc
Mar 27, 2026
Merged

remove gRPC PHP extension from build#32
itsrafsanjani merged 1 commit intoflywp:mainfrom
ma-04:chore/remove_grpc

Conversation

@ma-04
Copy link
Copy Markdown
Member

@ma-04 ma-04 commented Mar 16, 2026

Summary

The gRPC PHP extension is currently causing significant delays during the build process. Installing the extension via pecl install grpc takes a long time and produces very large binaries, which negatively impacts CI build times.

Several upstream issues indicate that this is a known problem with the gRPC PHP extension build process.

Details;
https://github.com/ma-04/flywp-dockerfiles/actions/runs/23083888353/job/67057476647

References

Problem

  • install-php-extensions install grpc significantly increases CI build time.
  • This negatively affects developer productivity and CI efficiency.

Temporary Solution

This PR removes the gRPC PHP extension from the build to avoid the slow installation during CI.

Future Improvements

We can reintroduce gRPC once we implement one of the following:

  • GitHub Actions caching for compiled extensions
  • Prebuilt PHP extensions in the base Docker image
  • Use the new pkg-config / with-grpc-dir support once it becomes stable upstream

Impact

  • Faster CI builds
  • Smaller Docker image layers
  • No functional impact if gRPC is not currently required

Notes

If gRPC functionality becomes required in the future, we should revisit this and implement a proper caching or prebuilt extension strategy.

Fixes; https://github.com/flywp/issues/issues/435

Summary by CodeRabbit

  • Chores
    • Minor formatting update to build configuration.

Note: This release contains no functional changes or new features visible to end-users.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 16, 2026

Walkthrough

A blank line is added after the install-php-extensions command in the PHP Dockerfile, resulting in no functional changes to the image build process or configuration.

Changes

Cohort / File(s) Summary
PHP Dockerfile Formatting
php/Dockerfile
Added blank line after install-php-extensions command for improved spacing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 A space so small, yet clean and bright,
Between the lines, the formatting's right,
One blank line added with care,
A Docker file breathing fresh air! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to remove the gRPC PHP extension, but the diff only adds a blank line to the Dockerfile with no functional changes. The title does not match the actual changes in the diff. Verify whether the gRPC extension was actually removed from the Dockerfile, or update the title to reflect the minimal whitespace-only change being made.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ma-04 ma-04 changed the title Temporarily remove gRPC PHP extension from build due to slow installation and large binaries remove gRPC PHP extension from build Mar 27, 2026
@ma-04
Copy link
Copy Markdown
Member Author

ma-04 commented Mar 27, 2026

image

@itsrafsanjani itsrafsanjani merged commit 942d474 into flywp:main Mar 27, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants