chore: update to latest OLS version#33
Conversation
WalkthroughThis PR updates the OpenLiteSpeed version used in the Docker image by bumping the default ChangesOpenLiteSpeed Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
openlitespeed/Dockerfile (1)
7-7: ⚡ Quick winAdd checksum validation for the OpenLiteSpeed tarball.
The current Dockerfile downloads an external tarball without verifying its integrity. Since the version is parameterized and will be updated in future bumps, add a checksum ARG and validate the archive before extraction to prevent supply-chain risks.
Suggested implementation
ARG LSPHP=lsphp82 ARG OLS_VERSION=1.9.0 +ARG OLS_SHA256 ARG DEBIAN_FRONTEND=noninteractive ARG TARGETPLATFORM @@ - && wget "https://openlitespeed.org/packages/openlitespeed-$OLS_VERSION-$ARCH-linux.tgz" \ + && wget "https://openlitespeed.org/packages/openlitespeed-$OLS_VERSION-$ARCH-linux.tgz" \ + && echo "${OLS_SHA256} openlitespeed-$OLS_VERSION-$ARCH-linux.tgz" | sha256sum -c - \ && tar xzf openlitespeed-$OLS_VERSION-$ARCH-linux.tgz \Both release artifacts for version 1.9.0 are available for x86_64 and aarch64 architectures, so this approach is compatible with your multi-arch build strategy.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openlitespeed/Dockerfile` at line 7, The Dockerfile currently uses the build-time ARG OLS_VERSION without any checksum validation for the downloaded OpenLiteSpeed tarball; add a new ARG (e.g., OLS_SHA256) and modify the download/extract steps to verify the archive's SHA256 against that ARG before extraction—fail the build if the checksum does not match—so update the Dockerfile's tarball download block (the lines that reference ARG OLS_VERSION and perform curl/wget and tar -xzf) to perform a sha256sum (or similar) check using the new ARG prior to tar.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@openlitespeed/Dockerfile`:
- Line 7: The Dockerfile currently uses the build-time ARG OLS_VERSION without
any checksum validation for the downloaded OpenLiteSpeed tarball; add a new ARG
(e.g., OLS_SHA256) and modify the download/extract steps to verify the archive's
SHA256 against that ARG before extraction—fail the build if the checksum does
not match—so update the Dockerfile's tarball download block (the lines that
reference ARG OLS_VERSION and perform curl/wget and tar -xzf) to perform a
sha256sum (or similar) check using the new ARG prior to tar.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ffdedf90-68db-4cd0-823c-1543b42ec85c
📒 Files selected for processing (1)
openlitespeed/Dockerfile
|
Resolves #33 |
Summary by CodeRabbit