Skip to content

merge with upstream#4

Closed
ma-04 wants to merge 4 commits into
flywp:masterfrom
mcuadros:master
Closed

merge with upstream#4
ma-04 wants to merge 4 commits into
flywp:masterfrom
mcuadros:master

Conversation

@ma-04
Copy link
Copy Markdown
Member

@ma-04 ma-04 commented May 11, 2026

Summary by CodeRabbit

  • New Features

    • Added Entrypoint parameter to allow overriding the default container entrypoint in jobs.
  • Chores

    • Updated Go toolchain to 1.26.2.
    • Updated mage dependency to 1.17.1.
    • Updated test pipeline to run on additional branch patterns.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Walkthrough

This PR adds support for custom container entrypoints to the RunJob configuration. A new optional Entrypoint field is added to RunJob, integrated into the container build process, thoroughly tested with table-driven cases, and documented. Go toolchain and dependencies are updated, and CI workflow is extended for renovate branches.

Changes

Entrypoint Support for RunJob

Layer / File(s) Summary
Data Model
core/runjob.go
RunJob struct gains optional Entrypoint *string field to support custom container entrypoint overrides.
Container Configuration
core/runjob.go
buildContainer() is refactored to construct docker.Config in a local variable and conditionally set config.Entrypoint from j.Entrypoint when provided. CreateContainer call updated to use the constructed config variable.
Testing
core/runjob_test.go
TestRun converted to table-driven test parameterizing entrypoint as nil, override string "/bin/bash -c", and empty string, asserting Config.Entrypoint matches expected parsed values while preserving existing assertions for Cmd, User, Image, and container lifecycle.
Documentation
docs/jobs.md
New Entrypoint parameter documented in Job-run section with description, example syntax, and note that default is container entrypoint.
Infrastructure & Dependencies
.github/workflows/test.yml, go.mod
GitHub Actions test workflow extended to run on renovate/** branches. Go toolchain bumped from go1.26.1 to go1.26.2 and github.com/magefile/mage updated from v1.16.1 to v1.17.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A new entrypoint hops into place,
Docker containers run at their own pace,
Tests dance through cases, three at a time,
Dependencies updated—everything's prime,
From renovate branches to Go's latest release,
This PR brings order and elegant peace.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'merge with upstream' is too vague and generic; it does not clearly describe the specific changes made (Entrypoint support, workflow updates, dependency upgrades, and documentation). Use a more descriptive title that highlights the primary change, such as 'Add Entrypoint field support to RunJob' or 'Support optional container entrypoint override'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch master

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 5: Remove the invalid toolchain directive from go.mod: delete the line
containing "toolchain go1.26.2" so only the valid base Go version (e.g., the
existing "go 1.25" entry) remains; if a specific toolchain is required, replace
it only with a confirmed release from https://go.dev/dl and ensure any
references to "toolchain" in go.mod match an actual Go release.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 291dfbfe-0713-4504-9d85-3ad27be57dae

📥 Commits

Reviewing files that changed from the base of the PR and between 34bc51d and 32b612a.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • .github/workflows/test.yml
  • core/runjob.go
  • core/runjob_test.go
  • docs/jobs.md
  • go.mod

Comment thread go.mod
@ma-04
Copy link
Copy Markdown
Member Author

ma-04 commented May 12, 2026

closed in favour of #5

@ma-04 ma-04 closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants