Skip to content

Merge with upstream#6

Merged
itsrafsanjani merged 5 commits into
masterfrom
merge_with_upstream
May 14, 2026
Merged

Merge with upstream#6
itsrafsanjani merged 5 commits into
masterfrom
merge_with_upstream

Conversation

@ma-04
Copy link
Copy Markdown
Member

@ma-04 ma-04 commented May 14, 2026

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for customizing container entrypoint configuration in job runs.
  • Documentation

    • Updated documentation to include the new Entrypoint parameter.
  • Tests

    • Enhanced test coverage for entrypoint configuration scenarios.
  • Chores

    • Updated Go toolchain and build dependencies to latest versions.
    • Improved test automation workflow for additional branch patterns.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR adds optional container entrypoint override support to the RunJob struct. The Entrypoint *string field allows users to specify a custom entrypoint, which is applied to the container configuration during job execution. The change includes table-driven test validation, parameter documentation, and routine dependency updates.

Changes

Entrypoint Feature

Layer / File(s) Summary
Entrypoint field and container configuration
core/runjob.go
RunJob struct adds Entrypoint *string field. Container configuration conditionally sets config.Entrypoint from the field when non-nil using args.GetArgs().
Table-driven test coverage for entrypoint
core/runjob_test.go
TestRun is refactored into a table-driven test with cases exercising nil and empty-string entrypoint inputs paired with corresponding container.Config.Entrypoint assertions.
Documentation and build configuration
docs/jobs.md, .github/workflows/test.yml, go.mod
Entrypoint parameter documented in job-run spec; CI workflow adds renovate/** branch trigger; Go toolchain upgraded from 1.26.1 to 1.26.2 and Mage dependency from v1.16.1 to v1.17.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • flywp/ofelia#5: Overlaps with identical RunJob.Entrypoint field addition, table-driven test refactoring, and renovate/** CI trigger update.

Poem

🐰 A little entrypoint to override the way,
Containers start fresh in their new Docker play.
Tests march in tables, docs explain it clear,
Dependencies updated—no renovate fear!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Merge with upstream' is too vague and generic. It doesn't describe the actual changes: adding Entrypoint support to RunJob, updating GitHub Actions workflow, and upgrading dependencies. Use a more specific title that reflects the main change, such as 'Add Entrypoint configuration support to RunJob' or 'Support custom container entrypoints'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch merge_with_upstream

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@itsrafsanjani itsrafsanjani merged commit cafc986 into master May 14, 2026
10 of 11 checks passed
@ma-04 ma-04 deleted the merge_with_upstream branch May 14, 2026 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants