Skip to content

Conversation

@luminisward
Copy link
Contributor

HTTP support only temporarily
HTTPS uses SafeTransport class

@fmenabe
Copy link
Owner

fmenabe commented Mar 14, 2018

The changes you made breaks calls to my company wiki. When CookieTransport is used, the wiki returns a redirect (302) which generate this error:

ProtocolError: <ProtocolError for ********/lib/exe/xmlrpc.php: 302 Found>

The problem is visible in the apache logs:

# without CookieTransport.
xxxxxxx - - [14/Mar/2018:20:39:40 +0100] "POST /lib/exe/xmlrpc.php HTTP/1.1" 200 163 "-" "Python-xmlrpc/3.6"
# with CookieTransport.
xxxxxxx - - [14/Mar/2018:20:39:45 +0100] "POST /lib/exe/xmlrpc.php HTTP/1.1" 302 291 "-" "Python-xmlrpc/3.6"

It seems that the problem is from Dokuwiki server but I don't really understand the origin (misconfiguration of Dokuwiki, htaccess, ...). If you have any idea?

I'm not sure it will also break for other users so I prefer to add a parameter (cookieAuth) for making cookie authentication optional. I not really sure how to update your pull request before merging it, so I pushed a commit (b5e9d8b) for this behaviour in the luminisward-master branch.

@luminisward
Copy link
Contributor Author

Sorry I didn't take it into consideration, thank you for point out the problem. I set the parameter (cookieAuth) disabled, so it should work for old users.

@fmenabe fmenabe merged commit e452140 into fmenabe:master Mar 22, 2018
@fmenabe
Copy link
Owner

fmenabe commented Mar 22, 2018

I merge your pull request and release a new version (1.1.0) on PyPI.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants