ADd option to include identity line in pairs plots; select points to …#34
ADd option to include identity line in pairs plots; select points to …#34
Conversation
…label in result plots based on nominal p-value to avoid ties.
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
- Coverage 97.10% 96.90% -0.21%
==========================================
Files 20 20
Lines 2176 2196 +20
==========================================
+ Hits 2113 2128 +15
- Misses 63 68 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mbstadler
left a comment
There was a problem hiding this comment.
All great here. I have added a small rewording in the argument documentation of the plotVolcano and plotMeanDiff functions, feel free to revert if you prefer to original wording.
I also got all green tests under arm64. The coverage of plotPairs.R (based on covr::report()) is incomplete, but the output makes no sense (e.g. it is calling smoothscat 15 times, but the sole expression in the function body is reported as uncovered), so I think there is not much we can do and this is probably an issue in covr, rather than a true positive.
|
Yes, I'm also not sure what's happening with the coverage in |
…label in result plots based on nominal p-value to avoid ties.