Show console in runner for non-graphical code#90
Open
nimec01 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the standalone runner (web/run.html + web/js/run.js) so that programs that do not produce graphics (no #screen canvas) can still display their runtime output on the runner page, addressing the request in #89.
Changes:
- Adds a
#messageoutput container torun.htmland styles it for runner use. - Prints runtime stdout/stderr messages into the runner page via
printMessage. - Adjusts the “show graphics” detection to hide the console once a
#screencanvas is created.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
web/run.html |
Adds a console output <pre id="message"> and includes runner.css so the runner can show non-graphical output. |
web/js/run.js |
Routes runtime output through printMessage and hides the console when a graphics canvas is detected. |
web/css/runner.css |
Adds runner-specific styling for the message area. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+231
to
+237
| const canvasAdded = mutations.some(mutation => | ||
| [...mutation.addedNodes].some( | ||
| node => node.nodeName === 'CANVAS' && node.id === 'screen' | ||
| ) | ||
| ); | ||
|
|
||
| if (!canvasAdded) return; |
Comment on lines
108
to
114
| function addMessage(type, str) { | ||
| const recentStart = Date.now() - window.programStartTime < 1000; | ||
| const printDeferred = window.hasObservableOutput || !recentStart; | ||
|
|
||
| printMessage(type,str); | ||
|
|
||
| window.hasObservableOutput = true; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89