Fs Grid data interpolation#164
Merged
markusbattarbee merged 12 commits intofmihpc:masterfrom Aug 22, 2022
Merged
Conversation
Contributor
Author
|
Maybe @markusbattarbee @ursg @ykempf can have a look at this. |
markusbattarbee
requested changes
Feb 14, 2022
Contributor
markusbattarbee
left a comment
There was a problem hiding this comment.
Additional comments on how output should be handled:
If a point is outside of a non periodic domain: Return None(s). We don't have data there, let's use None.
If a point is outside of a periodic domain: just use modulo. 2D particle pusher particles can travel quite far in the out-of-plane direction so let's retain compatibility with that.
If a point is inside the domain but one of its neighbors cannot be located: indeed keep a is, return a NaN is returned. We don't want to hide errors in finding/interpolating data!
Also, I would recommend returning a numpy array instead of a list.
markusbattarbee
requested changes
Aug 22, 2022
Contributor
markusbattarbee
left a comment
There was a problem hiding this comment.
One last fix for periodicity please! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a trilinear interpolation routine for FsGrid data and tries to resolve issue #136 .
Boundaries are handled the following way:
Have tested this with 2D runs, AMR on/off 3D runs, periodic dimensions , scalar and vector variables.
Example of interpolation in an AMR test run :
