No mathrm pascals as non latex units, another fallthrough for variable scaler#175
Merged
markusbattarbee merged 2 commits intofmihpc:masterfrom Sep 22, 2022
Merged
Conversation
…lar strings, except for pressure variables, that had a LaTeX mathrm wrapper. VariableInfo.latexunits is a thing, so no reason for latex in the unit string. Conflicts with the variable scaler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: problem with missing \mathrm{Pa} units in dict - datareducers use \mathrm{Pa} for pressure units (while there is a latexunits separately). Homogenized this to match other reducres, and added a fallthrough for variable scaler so it will still scale if needed (will complain though).