vlsvReader improvements#184
Merged
markusbattarbee merged 15 commits intofmihpc:masterfrom May 5, 2023
Merged
Conversation
Merged
…Should vg_coordinates be deprecated in favour of explicit cellcenter coordinate reducer?
markusbattarbee
requested changes
May 5, 2023
Contributor
markusbattarbee
left a comment
markusbattarbee
left a comment
There was a problem hiding this comment.
Yes, this vlsvreader approach for passing the reader to data reducers is exactly what was needed, and a very elegant implementation. Thank you! Just need to reduce some bloat by removing those duplicate call functions, and one optimization request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast SpatialGrid coordinate extraction (plus AMR level and dx extraction), accessible also via
read_variable("vg_dxs")andread_variable("vg_coordinates")- needed special handling though, since I want to use these in xo_tools datareducers.