Write none checks#200
Merged
markusbattarbee merged 3 commits intofmihpc:masterfrom Sep 26, 2023
Merged
Conversation
…nd cleaning out incomplete XML nodes
markusbattarbee
approved these changes
Sep 1, 2023
Contributor
markusbattarbee
left a comment
markusbattarbee
left a comment
There was a problem hiding this comment.
Looks good. Ready to merge or more coming in?
Member
Author
|
I'm on the fence about still changing the warnings to errors - thoughts either way? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kosta found weird XML entries in vlsv footers. Here's some guards against having incomplete XML elements written to .vlsv files; also more warnings (although not errors) for writing ill-formed data; with the reasoning that in case some pipeline fails, we don't necessarily want to throw away all results from a possibly length script... but could also be errors instead to enforce well-behaved code.