Isosurfaces#229
Merged
markusbattarbee merged 7 commits intofmihpc:masterfrom Jun 11, 2024
Merged
Conversation
Updated with the latest changes from upstream/master
…st fold transparency, adjusted folding criteria to decrease false folds
alhom
reviewed
Mar 21, 2024
|
|
||
| for i in range(len(all_x)): | ||
| key = str(round(all_x[i]/1e6))+"_"+str(round(all_y[i]/1e6)) # Key for hashing XY coordinates, precise to one cell | ||
| key = str(round(all_x[i]/1e6))+"_"+str(round(all_y[i]/1e6)) # Key for hashing xy coordinates, precise to one cell |
Member
There was a problem hiding this comment.
Tuples work as keys since they are hashable, would be a bit prettier.
I would also suggest rounding to fsgrid dx instead of 1e6 for a bit more of genericity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plot_neutral_sheet: Fixed minor tick issues and added better handling of sheet folding