Skip to content

Refresh the Python FDK dependencies to more recent versions.#106

Merged
harshpai merged 1 commit intomasterfrom
version-bump
Jun 4, 2020
Merged

Refresh the Python FDK dependencies to more recent versions.#106
harshpai merged 1 commit intomasterfrom
version-bump

Conversation

@harshpai
Copy link
Copy Markdown
Contributor

@harshpai harshpai commented May 30, 2020

Updated the dependency versions as follows:

pbr==5.4.5
pytest==5.4.3
pytest-asyncio==0.12.0
httptools>=0.1.1
pytest-cov==2.9.0

The version upgrade caused deprecation of imp library and it is now replaced with importlib.

Built and tested successfully by running:

- python3 -m venv .venv && source .venv/bin/activate
- pip install tox
- tox

Copy link
Copy Markdown
Contributor

@reclaro reclaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@riconnon riconnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@harshpai harshpai removed the request for review from zootalures June 4, 2020 23:25
@harshpai harshpai merged commit f62dde5 into master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants