Updated copyright headers, added NOTICE.txt and updated THIRD_PARTY_LICENSES.txt#112
Merged
Updated copyright headers, added NOTICE.txt and updated THIRD_PARTY_LICENSES.txt#112
Conversation
templecloud
approved these changes
Oct 16, 2020
templecloud
left a comment
templecloud
left a comment
There was a problem hiding this comment.
Looks good to me. Just changes to comments, no code changes as expected. Tests pass.
isaaclipszyc
force-pushed
the
copyright-fix
branch
2 times, most recently
from
8fa370b to
4bec9a9
Compare
…ICENSES.txt Removed copyright header in /fdk/test/__init__.py due to failing circleci test Removed header from /fdk/async_http/__init__.py due to failing circleci test THIRD_PARTY_LICENSES.txt clean up Updated THIRD_PARTY_LICENSES.txt Added fourth party dev dependencies to THIRD_PARTY_LICENSES.txt
isaaclipszyc
force-pushed
the
copyright-fix
branch
from
4bec9a9 to
a58f94f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed copyright header in /fdk/test/init.py due to failing circleci test
Removed header from /fdk/async_http/init.py due to failing circleci test
What I did
Added copyright headers to all files with source code and updated old copyright headers. Added NOTICE.txt file to repo top level. Updated THIRD_PARTY_LICENSES.txt.
How to verify it
Copyright headers have been added/updated and are located at the top of files with source code in it.
Both init.py files in /fdk/test/ and /fdk/async_http do not have the header in as these are blank files and adding in these headers will cause circleci to fail some tests (tests that expect these files to be empty).