Skip to content

Bumped Python version of runtime and CI#115

Merged
metamemelord merged 3 commits intofnproject:masterfrom
metamemelord:3.x-version-bump
Apr 19, 2021
Merged

Bumped Python version of runtime and CI#115
metamemelord merged 3 commits intofnproject:masterfrom
metamemelord:3.x-version-bump

Conversation

@metamemelord
Copy link
Copy Markdown
Contributor

@metamemelord metamemelord commented Mar 24, 2021

This PR introduces Python 3.8 and Python 3.7 into FDK.

Copy link
Copy Markdown

@theatul theatul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though i am not familiar with code base enough but version changes seem consistent to me.

Comment thread images/build-stage/3.7/Dockerfile Outdated
Comment thread build-images.sh Outdated
Copy link
Copy Markdown

@theatul theatul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me other than one nit.

@metamemelord metamemelord force-pushed the 3.x-version-bump branch 3 times, most recently from 1c7abc5 to fe44a5b Compare April 9, 2021 11:01
- Added scripts to build images properly
@riconnon riconnon self-requested a review April 15, 2021 08:46
Copy link
Copy Markdown
Contributor

@riconnon riconnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This largely looks fine...
I'm curious about the rationale behind keeping 3.7.1 and 3.8.5 approved nonetheless

@metamemelord
Copy link
Copy Markdown
Contributor Author

@riconnon this is to maintain backward compatibility. We had discussions with Sachin and we concluded that existing functions should not bump 3.8.5 to 3.8.8 internally. Hence all the functions that use Python 3.7.1 and Python 3.8.5 will continue working but no new apps can be created with these versions.

Also, this is the first phase of FDK work. We plan to send out all the breaking changes in the third phase which includes discontinuation of support for 3.8.5 and 3.7.1.

@metamemelord metamemelord merged commit 772963d into fnproject:master Apr 19, 2021
@metamemelord metamemelord deleted the 3.x-version-bump branch April 19, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants