fix gateway headers / headers casing#88
Merged
denismakogon merged 1 commit intomasterfrom Jun 21, 2019
Merged
Conversation
the http library we're using automatically lower cases headers, and we weren't properly handling different cases when encapsulating certain headers such as content type and the gateway headers. this changes most of the headers to be turned into lower case to check them and lower cases them going out of the response in order to test them as well. over the wire itself, fn via the go http library will end up turning these into the canonical header casing, but for consistency in python this seems ideal. there are tests to ensure these are checked properly in various cases now. closes #87
denismakogon
approved these changes
Jun 21, 2019
Contributor
Author
|
thanks! |
|
the Content-Type: None additional header is back, though at least now it's consistant, so there's that. |
Contributor
Author
|
yep, think I found it. from what I can tell this is all a mess from us stripping out the case insensitive headers dictionary that sanic was using when we vendored it (probably, to make things fast). can monkey patch but we should probably figure out something more sane and maintainable cc @denismakogon |
Contributor
Author
|
@fmtovland this seems to do the trick: #90 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the http library we're using automatically lower cases headers, and we weren't
properly handling different cases when encapsulating certain headers such as
content type and the gateway headers. this changes most of the headers to be
turned into lower case to check them and lower cases them going out of the
response in order to test them as well. over the wire itself, fn via the go
http library will end up turning these into the canonical header casing, but
for consistency in python this seems ideal. there are tests to ensure these
are checked properly in various cases now.
closes #87